Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling in custom benchmark #22245

Merged
merged 26 commits into from
Sep 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove if
  • Loading branch information
jikim-msft committed Sep 4, 2024
commit 4322687544926b24b06110b225f7a6fb338f6831
5 changes: 0 additions & 5 deletions tools/benchmark/src/mocha/customOutputRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import { Test } from "mocha";

import {
isInPerformanceTestingMode,
type BenchmarkDescription,
type MochaExclusiveOptions,
type Titled,
Expand Down Expand Up @@ -64,10 +63,6 @@ export function benchmarkCustom(options: CustomBenchmarkOptions): Test {
// When running them without perf mode, we need to re-throw the error for Mocha to do its normal thing when a test throws.
test.emit("benchmark end", benchmarkError);

if (isInPerformanceTestingMode) {
return;
}

throw error;
jikim-msft marked this conversation as resolved.
Show resolved Hide resolved
jikim-msft marked this conversation as resolved.
Show resolved Hide resolved
}

Expand Down
Loading