Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ORC-587] Bundle import params #140

Merged
merged 12 commits into from
Sep 17, 2024
Merged

[ORC-587] Bundle import params #140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fc1a542
First cut at implementing re-importing of params
chrisghill Aug 15, 2024
7e6877a
more import utilities
chrisghill Sep 9, 2024
20c6a03
Full implementation before webinar
chrisghill Sep 10, 2024
6f1d1b0
move println to proper place
chrisghill Sep 10, 2024
1f38f3d
Merge branch 'main' into bundle-import-params
chrisghill Sep 10, 2024
e01fd07
Add tests and cleanup function a bit
chrisghill Sep 11, 2024
d839f4b
update help docs
chrisghill Sep 12, 2024
1c1f34b
remove unnecessary files
chrisghill Sep 12, 2024
e34df3f
remove unnecessary function
chrisghill Sep 12, 2024
b8a8573
update lint verbiage to use IaC instead of provisioner
chrisghill Sep 12, 2024
868cd63
updated docs
chrisghill Sep 17, 2024
021019c
lint fixes
chrisghill Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update lint verbiage to use IaC instead of provisioner
  • Loading branch information
@chrisghill
chrisghill committed Sep 12, 2024
commit b8a85738b130bab88e77c3367f718f6733135fe3
4 changes: 2 additions & 2 deletions pkg/bundle/lint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,10 @@ func (b *Bundle) LintInputsMatchProvisioner() error {
err := fmt.Sprintf("missing inputs detected in step %s:\n", step.Path)

for _, p := range missingMassdriverInputs {
err += fmt.Sprintf("\t- input \"%s\" declared in provisioner but missing massdriver.yaml declaration\n", p)
err += fmt.Sprintf("\t- input \"%s\" declared in IaC but missing massdriver.yaml declaration\n", p)
}
for _, v := range missingProvisionerInputs {
err += fmt.Sprintf("\t- input \"%s\" declared in massdriver.yaml but missing provisioner declaration\n", v)
err += fmt.Sprintf("\t- input \"%s\" declared in massdriver.yaml but missing IaC declaration\n", v)
}

return errors.New(err)
Expand Down
6 changes: 3 additions & 3 deletions pkg/bundle/lint_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,10 +336,10 @@ func TestLintInputsMatchProvisioner(t *testing.T) {
UI: map[string]interface{}{},
},
err: errors.New(`missing inputs detected in step testdata/lintmodule:
- input "bar" declared in provisioner but missing massdriver.yaml declaration
- input "bar" declared in IaC but missing massdriver.yaml declaration
`),
}, {
name: "Invalid missing provisioner input",
name: "Invalid missing IaC input",
bun: &bundle.Bundle{
Name: "example",
Description: "description",
Expand All @@ -361,7 +361,7 @@ func TestLintInputsMatchProvisioner(t *testing.T) {
UI: map[string]interface{}{},
},
err: errors.New(`missing inputs detected in step testdata/lintmodule:
- input "baz" declared in massdriver.yaml but missing provisioner declaration
- input "baz" declared in massdriver.yaml but missing IaC declaration
`),
},
}
Expand Down
Loading