[ORC-587] Bundle import params #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisghill
commented
Sep 12, 2024
| yaml3 "gopkg.in/yaml.v3" | ||
| ) | ||
|
|
||
| func ImportParams(buildPath string, skipVerify bool) error { |
There was a problem hiding this comment.
This function is currently too cluttered. Some of this functionality will be broken out into functions when we add capability like mass bundle add-connection or mass bundle add-artifact. Working with yaml nodes is not easy, but it does maintain structure and order in yaml files, allowing us to read and render with minimal extraneous changes.
mclacore
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new command
mass bundle importwhich will IaC in the declaredstepsand look for IaC variables not defined in theparamsblock of themassdriver.yaml.