Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Add notes-bar #6772

Merged
merged 109 commits into from
Sep 9, 2022
Merged
Changes from 1 commit
Commits
Show all changes
109 commits
Select commit Hold shift + click to select a range
f78ba7b
Refactor global-style.js into typescript
Tolu-Mals Jul 19, 2022
eaab3a8
Fix parameter type, change require to import
Tolu-Mals Jul 19, 2022
03b4d65
Make fontId and theme parameters optional
Tolu-Mals Jul 19, 2022
491b7fe
Add parameter type to connect()
Tolu-Mals Jul 19, 2022
d0a61f5
Change 'module.export..' syntax to 'export function...'
Tolu-Mals Jul 19, 2022
6fc6e4d
Change require to import
Tolu-Mals Jul 19, 2022
2e512ee
Add notesbar 1
Tolu-Mals Jul 23, 2022
13ecb86
Add notesbar 2
Tolu-Mals Jul 23, 2022
69d5573
Add notesbar 3, add JSX to eslint globals
Tolu-Mals Jul 23, 2022
a1d2368
Add notesbar 4
Tolu-Mals Jul 23, 2022
c39d30c
Add notesbar 5
Tolu-Mals Jul 24, 2022
2336d6f
Add notesbar 6
Tolu-Mals Jul 25, 2022
87f0187
Refactor checkbox.js into typescript
Tolu-Mals Jul 25, 2022
fd69dd5
Change checkbox.js imports to default imports
Tolu-Mals Jul 26, 2022
f7f5aef
Refactor checkbox.js to typescript 2, change checkbox.js imports 2
Tolu-Mals Jul 26, 2022
133a808
Add notesbar 7
Tolu-Mals Jul 26, 2022
ef3fa83
Add notesbar 8
Tolu-Mals Jul 30, 2022
edceebe
Add notesbar 9
Tolu-Mals Jul 30, 2022
a9266eb
Add note switching functionality to notesbar (Add notesbar 10)
Tolu-Mals Jul 31, 2022
8ad205f
Add note creation functionality(...11)
Tolu-Mals Aug 1, 2022
66b5d27
Highlight selected note (...11)
Tolu-Mals Aug 2, 2022
b3438ce
Scroll notesbar to selected note (...13)
Tolu-Mals Aug 2, 2022
e84eedf
Animate notesbar component
Tolu-Mals Aug 2, 2022
7be0e41
Add noteActionButton, notesbar opening animation
Tolu-Mals Aug 3, 2022
79a7366
Make notesbar fill screen height
Tolu-Mals Aug 4, 2022
400515a
Add showMobileNotesBar to global state and set up
Tolu-Mals Aug 4, 2022
d963bb7
Remove unused code
Tolu-Mals Aug 4, 2022
5d76d4b
Configure notesbar closing animation
Tolu-Mals Aug 4, 2022
72be3ab
Configure notesbar close button
Tolu-Mals Aug 4, 2022
735fd96
Add basic search functionality
Tolu-Mals Aug 5, 2022
8b42fbe
Make note action button group draggable
Tolu-Mals Aug 9, 2022
7026422
Change noteActions drag boundary for better UX
Tolu-Mals Aug 9, 2022
0732753
Fix styling issues
Tolu-Mals Aug 9, 2022
e11a98f
Fix notesbar update issues, Simply notesbar search
Tolu-Mals Aug 10, 2022
590cc5e
Fix styling issues
Tolu-Mals Aug 10, 2022
ac303c6
Set up jest in mobile app
Tolu-Mals Jun 15, 2022
06c042b
Write and test getResponsiveValue() part 1
Tolu-Mals Jun 17, 2022
f12d58c
Write and test getResponsiveValue() part 2
Tolu-Mals Jun 17, 2022
bb1767b
Change responsive breakpoints
Tolu-Mals Jun 18, 2022
62fc00d
Set up jest
Tolu-Mals Jun 18, 2022
d79f91a
Remove jest set up files
Tolu-Mals Jun 19, 2022
8553087
Write and test getResponsiveValue() part 3
Tolu-Mals Jun 20, 2022
da39fa2
Write and test getResponsiveValue() part 4
Tolu-Mals Jun 20, 2022
86d0cb7
Write and test getResponsiveValue() part 5
Tolu-Mals Jun 21, 2022
4e2013f
Refactor side-menu.js into Typescript, update react-native-side-menu …
Tolu-Mals Jun 21, 2022
e20745e
Make side-menu width responsive 1
Tolu-Mals Jun 23, 2022
1bf722f
Remove array syntax code, modify first test
Tolu-Mals Jun 29, 2022
5fe10e8
Rename side-menu.ts into sideMenu.ts
Tolu-Mals Jun 30, 2022
7647230
Change require() to import to support type checking
Tolu-Mals Jun 30, 2022
1692490
Refactor code,make menu width progressively larger
Tolu-Mals Jul 9, 2022
bc0a284
Remove SideMenu Key
Tolu-Mals Jul 11, 2022
0ee5545
Tolu-Mals Jul 12, 2022
ba50a4e
Tolu-Mals Jul 12, 2022
93cc827
Rename sideMenu.ts to SideMenu.ts
Tolu-Mals Jul 13, 2022
0705731
Allow zero value in getResponsiveValue
Tolu-Mals Jul 13, 2022
5e08692
Make getSideMenuWidth a private method
Tolu-Mals Jul 14, 2022
7f68b85
Tolu-Mals Jul 14, 2022
5bce6d1
Tolu-Mals Jul 23, 2022
7a6fd54
Tolu-Mals Jul 24, 2022
3cd3e3c
add gulpfile.js
Tolu-Mals Jul 24, 2022
0c1dea5
Add @types/fs-extra
Tolu-Mals Jul 24, 2022
527b7ce
Remove gulpfile.js
Tolu-Mals Jul 24, 2022
6e056db
Tolu-Mals Jul 24, 2022
2ce49f3
Use strict equality to fix eslint error
Tolu-Mals Jul 24, 2022
de2874b
Refactor getResponsiveValue.ts 2
Tolu-Mals Jul 25, 2022
a80654f
Make notesbar width responsive
Tolu-Mals Aug 12, 2022
0ee1a32
Make notesbar render only on tablet devices(>= 768px widths)
Tolu-Mals Aug 12, 2022
3f23da1
Unsubscribe from screen width change event listener
Tolu-Mals Aug 12, 2022
721737c
Fix typescript editor bugs
Tolu-Mals Aug 16, 2022
7c16e2a
Add useful comments
Tolu-Mals Aug 16, 2022
d572b85
Set up react native testing libary
Tolu-Mals Aug 16, 2022
1bead06
Downgrade jest version to fix bug
Tolu-Mals Aug 16, 2022
87cd82a
Fix jest errors
Tolu-Mals Aug 16, 2022
0950bdc
Fix 'Component' cannot be used as a JSX component
Tolu-Mals Aug 16, 2022
357c097
Add @types/node to tsconfig types
Tolu-Mals Aug 17, 2022
2f71736
Upgrade jest to version 28
Tolu-Mals Aug 18, 2022
d998885
Fix jest type errors
Tolu-Mals Aug 18, 2022
433ab2f
Change function to arrow function
Tolu-Mals Aug 23, 2022
bf990e0
Refactor NotesBar 1
Tolu-Mals Aug 23, 2022
1b0e099
Refactor NotesBar 2
Tolu-Mals Aug 23, 2022
28aa7b3
Refactor NotesBar 2
Tolu-Mals Aug 23, 2022
b3c1186
Refactor checkbox.tsx
Tolu-Mals Aug 23, 2022
ffd59c3
Refactor NotesBar 4
Tolu-Mals Aug 25, 2022
9a560a6
Update yarn.lock
Tolu-Mals Aug 26, 2022
afe9b33
Change require to import
Tolu-Mals Aug 27, 2022
e4c1c0a
Replace deprecated MenuContext with MenuProvider
Tolu-Mals Aug 27, 2022
75e7ae5
Fix themeId typing in theme.ts, fix linter issues
Tolu-Mals Aug 27, 2022
7b4aee1
Hide split layout toggle button for now
Tolu-Mals Aug 27, 2022
8f5d5fd
Fix notesbar scroll bug
Tolu-Mals Aug 27, 2022
1bc2e2c
Refactor styling into useStyles hook
Tolu-Mals Aug 27, 2022
f2b2f45
Memoize renderItem callback
Tolu-Mals Aug 27, 2022
ca8024a
Merge branch 'dev' into tl-notesbar
Tolu-Mals Aug 27, 2022
8eade79
Remove unused prop, rename item prop to notes
Tolu-Mals Aug 29, 2022
a9bf50b
Put useStyles(now styles())in each component.
Tolu-Mals Aug 29, 2022
f1bb2b1
Refactor, fix linter issues
Tolu-Mals Aug 30, 2022
2753836
Fix typescript error
Tolu-Mals Aug 31, 2022
ec1bd91
Merge branch 'dev' into tl-notesbar
Tolu-Mals Aug 31, 2022
dd42c1e
Modify notesbar open and close logic
Tolu-Mals Aug 31, 2022
a451475
Change require to import to support typing
Tolu-Mals Sep 1, 2022
0fd4a09
Fix notesbar toggle button bug
Tolu-Mals Sep 1, 2022
c0c5bce
Fix typing, small change
Tolu-Mals Sep 1, 2022
cfd4525
Fix notesbar toggle button bug
Tolu-Mals Sep 1, 2022
d0342d5
Add accessibility label to button
Tolu-Mals Sep 1, 2022
4d87003
Merge branch 'tl-notesbar' of https://github.com/Tolu-Mals/joplin int…
Tolu-Mals Sep 1, 2022
f72af41
Add a11y button and role to renderIconButton
Tolu-Mals Sep 1, 2022
08408f6
Refactor handleQuerySubmit
Tolu-Mals Sep 1, 2022
aeca65d
Refactor NotesBar
Tolu-Mals Sep 5, 2022
1a67fd9
Refactor search logic in Notesbar component and search screen component
Tolu-Mals Sep 6, 2022
b255987
Refactor note search logic
Tolu-Mals Sep 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add parameter type to connect()
  • Loading branch information
Tolu-Mals committed Aug 26, 2022
commit 491b7fef5f10c5aa14cbccaf961708404bc87b28
3 changes: 2 additions & 1 deletion packages/app-mobile/components/screens/Note.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import uuid from '@joplin/lib/uuid';
import Setting from '@joplin/lib/models/Setting';
import shim from '@joplin/lib/shim';
import UndoRedoService from '@joplin/lib/services/UndoRedoService';
import { State } from '@joplin/lib/reducer';
import NoteBodyViewer from '../NoteBodyViewer/NoteBodyViewer';
import checkPermissions from '../../utils/checkPermissions';
import NoteEditor from '../NoteEditor/NoteEditor';
Expand Down Expand Up @@ -1225,7 +1226,7 @@ class NoteScreenComponent extends BaseScreenComponent {
}
}

const NoteScreen = connect((state: any) => {
const NoteScreen = connect((state: State) => {
return {
noteId: state.selectedNoteIds.length ? state.selectedNoteIds[0] : null,
noteHash: state.selectedNoteHash,
Expand Down