-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile: Add notes-bar #6772
Merged
Merged
Mobile: Add notes-bar #6772
Changes from 1 commit
Commits
Show all changes
109 commits
Select commit
Hold shift + click to select a range
f78ba7b
Refactor global-style.js into typescript
Tolu-Mals eaab3a8
Fix parameter type, change require to import
Tolu-Mals 03b4d65
Make fontId and theme parameters optional
Tolu-Mals 491b7fe
Add parameter type to connect()
Tolu-Mals d0a61f5
Change 'module.export..' syntax to 'export function...'
Tolu-Mals 6fc6e4d
Change require to import
Tolu-Mals 2e512ee
Add notesbar 1
Tolu-Mals 13ecb86
Add notesbar 2
Tolu-Mals 69d5573
Add notesbar 3, add JSX to eslint globals
Tolu-Mals a1d2368
Add notesbar 4
Tolu-Mals c39d30c
Add notesbar 5
Tolu-Mals 2336d6f
Add notesbar 6
Tolu-Mals 87f0187
Refactor checkbox.js into typescript
Tolu-Mals fd69dd5
Change checkbox.js imports to default imports
Tolu-Mals f7f5aef
Refactor checkbox.js to typescript 2, change checkbox.js imports 2
Tolu-Mals 133a808
Add notesbar 7
Tolu-Mals ef3fa83
Add notesbar 8
Tolu-Mals edceebe
Add notesbar 9
Tolu-Mals a9266eb
Add note switching functionality to notesbar (Add notesbar 10)
Tolu-Mals 8ad205f
Add note creation functionality(...11)
Tolu-Mals 66b5d27
Highlight selected note (...11)
Tolu-Mals b3438ce
Scroll notesbar to selected note (...13)
Tolu-Mals e84eedf
Animate notesbar component
Tolu-Mals 7be0e41
Add noteActionButton, notesbar opening animation
Tolu-Mals 79a7366
Make notesbar fill screen height
Tolu-Mals 400515a
Add showMobileNotesBar to global state and set up
Tolu-Mals d963bb7
Remove unused code
Tolu-Mals 5d76d4b
Configure notesbar closing animation
Tolu-Mals 72be3ab
Configure notesbar close button
Tolu-Mals 735fd96
Add basic search functionality
Tolu-Mals 8b42fbe
Make note action button group draggable
Tolu-Mals 7026422
Change noteActions drag boundary for better UX
Tolu-Mals 0732753
Fix styling issues
Tolu-Mals e11a98f
Fix notesbar update issues, Simply notesbar search
Tolu-Mals 590cc5e
Fix styling issues
Tolu-Mals ac303c6
Set up jest in mobile app
Tolu-Mals 06c042b
Write and test getResponsiveValue() part 1
Tolu-Mals f12d58c
Write and test getResponsiveValue() part 2
Tolu-Mals bb1767b
Change responsive breakpoints
Tolu-Mals 62fc00d
Set up jest
Tolu-Mals d79f91a
Remove jest set up files
Tolu-Mals 8553087
Write and test getResponsiveValue() part 3
Tolu-Mals da39fa2
Write and test getResponsiveValue() part 4
Tolu-Mals 86d0cb7
Write and test getResponsiveValue() part 5
Tolu-Mals 4e2013f
Refactor side-menu.js into Typescript, update react-native-side-menu …
Tolu-Mals e20745e
Make side-menu width responsive 1
Tolu-Mals 1bf722f
Remove array syntax code, modify first test
Tolu-Mals 5fe10e8
Rename side-menu.ts into sideMenu.ts
Tolu-Mals 7647230
Change require() to import to support type checking
Tolu-Mals 1692490
Refactor code,make menu width progressively larger
Tolu-Mals bc0a284
Remove SideMenu Key
Tolu-Mals 0ee5545
ba50a4e
93cc827
Rename sideMenu.ts to SideMenu.ts
Tolu-Mals 0705731
Allow zero value in getResponsiveValue
Tolu-Mals 5e08692
Make getSideMenuWidth a private method
Tolu-Mals 7f68b85
5bce6d1
7a6fd54
3cd3e3c
add gulpfile.js
Tolu-Mals 0c1dea5
Add @types/fs-extra
Tolu-Mals 527b7ce
Remove gulpfile.js
Tolu-Mals 6e056db
2ce49f3
Use strict equality to fix eslint error
Tolu-Mals de2874b
Refactor getResponsiveValue.ts 2
Tolu-Mals a80654f
Make notesbar width responsive
Tolu-Mals 0ee1a32
Make notesbar render only on tablet devices(>= 768px widths)
Tolu-Mals 3f23da1
Unsubscribe from screen width change event listener
Tolu-Mals 721737c
Fix typescript editor bugs
Tolu-Mals 7c16e2a
Add useful comments
Tolu-Mals d572b85
Set up react native testing libary
Tolu-Mals 1bead06
Downgrade jest version to fix bug
Tolu-Mals 87cd82a
Fix jest errors
Tolu-Mals 0950bdc
Fix 'Component' cannot be used as a JSX component
Tolu-Mals 357c097
Add @types/node to tsconfig types
Tolu-Mals 2f71736
Upgrade jest to version 28
Tolu-Mals d998885
Fix jest type errors
Tolu-Mals 433ab2f
Change function to arrow function
Tolu-Mals bf990e0
Refactor NotesBar 1
Tolu-Mals 1b0e099
Refactor NotesBar 2
Tolu-Mals 28aa7b3
Refactor NotesBar 2
Tolu-Mals b3c1186
Refactor checkbox.tsx
Tolu-Mals ffd59c3
Refactor NotesBar 4
Tolu-Mals 9a560a6
Update yarn.lock
Tolu-Mals afe9b33
Change require to import
Tolu-Mals e4c1c0a
Replace deprecated MenuContext with MenuProvider
Tolu-Mals 75e7ae5
Fix themeId typing in theme.ts, fix linter issues
Tolu-Mals 7b4aee1
Hide split layout toggle button for now
Tolu-Mals 8f5d5fd
Fix notesbar scroll bug
Tolu-Mals 1bc2e2c
Refactor styling into useStyles hook
Tolu-Mals f2b2f45
Memoize renderItem callback
Tolu-Mals ca8024a
Merge branch 'dev' into tl-notesbar
Tolu-Mals 8eade79
Remove unused prop, rename item prop to notes
Tolu-Mals a9bf50b
Put useStyles(now styles())in each component.
Tolu-Mals f1bb2b1
Refactor, fix linter issues
Tolu-Mals 2753836
Fix typescript error
Tolu-Mals ec1bd91
Merge branch 'dev' into tl-notesbar
Tolu-Mals dd42c1e
Modify notesbar open and close logic
Tolu-Mals a451475
Change require to import to support typing
Tolu-Mals 0fd4a09
Fix notesbar toggle button bug
Tolu-Mals c0c5bce
Fix typing, small change
Tolu-Mals cfd4525
Fix notesbar toggle button bug
Tolu-Mals d0342d5
Add accessibility label to button
Tolu-Mals 4d87003
Merge branch 'tl-notesbar' of https://github.com/Tolu-Mals/joplin int…
Tolu-Mals f72af41
Add a11y button and role to renderIconButton
Tolu-Mals 08408f6
Refactor handleQuerySubmit
Tolu-Mals aeca65d
Refactor NotesBar
Tolu-Mals 1a67fd9
Refactor search logic in Notesbar component and search screen component
Tolu-Mals b255987
Refactor note search logic
Tolu-Mals File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make notesbar render only on tablet devices(>= 768px widths)
- Loading branch information
commit 0ee1a32ddc21fba07129e14141c42f4d351161b7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not async
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, thank you.