Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KED-1076] Add open flag to build-docs that opens the documentation on build #107

Merged
merged 12 commits into from
Oct 2, 2019
Merged

[KED-1076] Add open flag to build-docs that opens the documentation on build #107

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
468f328
Add option to open docs with build-docsc command
mzjp2 Sep 26, 2019
bfa7acd
Remove extraneous whitespace to make linter happy
mzjp2 Sep 26, 2019
871c20f
Merge branch 'develop' into feature/open-docs-option
mzjp2 Sep 28, 2019
4bc9f63
Patch shutil.rmtree in test in hopes it fixes Python3.5 problem
mzjp2 Sep 28, 2019
44235c0
Mock .resolve() since strict in Python3.5
mzjp2 Sep 29, 2019
4de17f9
AAdd myself to RELEASE.md
mzjp2 Sep 29, 2019
cc178f2
Merge branch 'develop' into feature/open-docs-option
mzjp2 Sep 30, 2019
651589e
Merge branch 'develop' into feature/open-docs-option
mzjp2 Sep 30, 2019
cbb4452
Update kedro_cli.py as per feedback
mzjp2 Oct 1, 2019
f526c76
Update tests as per feedback
mzjp2 Oct 1, 2019
d088d34
Remove extra newline I added from RELEASE.md
mzjp2 Oct 2, 2019
9386306
Merge branch 'develop' into feature/open-docs-option
DmitriiDeriabinQB Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Patch shutil.rmtree in test in hopes it fixes Python3.5 problem
  • Loading branch information
@mzjp2
mzjp2 committed Sep 28, 2019
commit 4bc9f63e9a633e598c4e981fb34b905029b4c9ab
6 changes: 5 additions & 1 deletion tests/template/test_kedro_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,14 +318,18 @@ def test_happy_path(self, call_mock, python_call_mock, fake_kedro_cli, mocker):
fake_rmtree.assert_called_once_with("docs/build", ignore_errors=True)

@pytest.mark.parametrize("open_flag", ["-o", "--open"])
def test_open_docs(self, open_flag, call_mock, python_call_mock, fake_kedro_cli, mocker):
def test_open_docs(
self, open_flag, call_mock, python_call_mock, fake_kedro_cli, mocker
):
fake_rmtree = mocker.patch("shutil.rmtree")
patched_browser = mocker.patch("webbrowser.open")
result = CliRunner().invoke(fake_kedro_cli.cli, ["build-docs", open_flag])
assert not result.exit_code, result.stdout
patched_browser.assert_called_once()
args, _ = patched_browser.call_args
for each in ("file://", os.path.join("docs", "build", "html", "index.html")):
assert each in args[0]
fake_rmtree.assert_called_once_with("docs/build", ignore_errors=True)


class TestBuildReqsCommand:
Expand Down