-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-1076] Add open flag to build-docs that opens the documentation on build #107
[KED-1076] Add open flag to build-docs that opens the documentation on build #107
Conversation
Turns out the issue was using pathlib's resolve, in Python3.5 if the filepath doesn't exist (as it doesn't when being mocked), an error is thrown, necessitating the use of mocking that method on the Path object. Incidentally, whilst researching this issue, I came across a few articles about the smell and danger of using I think this would be better if |
Not sure it's worth editing the documentation (https://github.com/quantumblacklabs/kedro/blob/develop/docs/source/03_tutorial/05_package_a_project.md or https://github.com/quantumblacklabs/kedro/blob/develop/docs/source/06_resources/01_faq.md) so I haven't, but if you think it should - I'm happy to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for picking this up! 🎉 I've left a couple of comments, happy to approve once they are addressed! :)
Just saw this, sorry. Maybe a note in |
Actually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👏
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
Motivation and Context
Why was this PR created?
Closes #86
How has this been tested?
What testing strategies have you used?
Similar testing strategy as
kedro.cli
withdocs
.Checklist
RELEASE.md
file