-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Camera Benchmark Tool and Allow Correct Unprojection of distance_to_camera depth image #976
base: main
Are you sure you want to change the base?
Add Camera Benchmark Tool and Allow Correct Unprojection of distance_to_camera depth image #976
Conversation
…ature/tiled_camera_examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few minor comments. Thanks for adding this useful tool 🎉
Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this tool!
I would have a proposal for the general usefulness. I find it hard to estimate how many cameras I can use in my actual scene, and I basically have to go back to the same trial and error as before, even if I used the benchmark. Personally, I would expect that I pass my scene definition (including robots, terrain, and other sensors), plus the intended data types, and then the script would add the different cameras, give me the memory consumption of each one of them, and tell me how much of each kind I can use.
Co-authored-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com> Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
Co-authored-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com> Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
Co-authored-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com> Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
Co-authored-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com> Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
Co-authored-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com> Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
Co-authored-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com> Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
Co-authored-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com> Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
Manager based vision cartpole MR at #995 uses same convert_perspective_depth_to_orthogonal_depth utility |
Signed-off-by: glvov-bdai <glvov@theaiinstitute.com>
depth is now aliased to distance_to_image_plane Signed-off-by: garylvov <67614381+garylvov@users.noreply.github.com>
Description
This change allows a user to easily test different camera settings/configurations to see what works best for them.
This also includes a fix to be able to correctly unproject point clouds from the
distance_to_camera
replicator,as the
unproject_depth
method assumes that data originates fromdistance_to_image_plane
replicator and as such could previously result in distortion when previously used with thedistance_to_camera
replicator.pyproject.toml
Type of change
Screenshots
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there