Fix setting incorrect device in env_cfg #1013
Open
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the issue where the device (
CPU
orCUDA
) is not set correctly when using the--device
argument in Hydra-configured scripts likersl_rl/train.py
andskrl/train.py
. The bug caused the scripts to always default tocuda:0
, even whencpu
or a specific CUDA device (e.g.,cuda:1
) was selected.The fix adds the following line to ensure that the selected device is properly set in
env_cfg
before initializing the environment withgym.make()
:Fixes # (issue)
[Bug Report] Incorrect device selection with Hydra configurations #1012
Type of change
Screenshots
Before:
[INFO]: Starting the simulation. This may take a few seconds. Please wait....
After:
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there