Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit actuator gain randomization #1005

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

MoreTore
Copy link

@MoreTore MoreTore commented Sep 20, 2024

Description

resolves: #1000
resolves: #1011
depends: #1006

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change may require a documentation update

Checklist

  • have run the pre-commit checks with ./isaaclab.sh --format
  • My changes generate no new warnings
  • I have added my name to the CONTRIBUTORS.md or my name already exists there
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file

@MoreTore
Copy link
Author

Can I have some guidance on how the test should be completed

@MoreTore
Copy link
Author

MoreTore commented Sep 20, 2024

in articulation.py we could set the default_joint_stiffness and default_joint_damping properly , instead of settings all zeros for explicit actuators. this would simplify this PR.
but for example in source/extensions/omni.isaac.lab/omni/isaac/lab/assets/articulation/articulation.py:

...
set defaults from the sim first
...


for actuator_name, actuator_cfg in self.cfg.actuators.items():
  if isinstance(actuator, ImplicitActuator):
     self.write_joint_xxx
     ...
  else:
     self.write_joint_xxx
     ...
     # over write the defaults we got from the sim with our local data
     self._data.default_joint_stiffness[slice(None), actuator.joint_indices] = (
        actuator._parse_joint_parameter(actuator.cfg.stiffness, actuator.stiffness)
     )
     self._data.default_joint_damping[slice(None), actuator.joint_indices] = (
        actuator._parse_joint_parameter(actuator.cfg.damping, actuator.damping)
     )

@MoreTore
Copy link
Author

Added my proposed changes to articulations.py to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant