-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit actuator gain randomization #1005
Open
MoreTore
wants to merge
8
commits into
isaac-sim:main
Choose a base branch
from
MoreTore:explicit-gain-randomization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+75
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoreTore
requested review from
jsmith-bdai,
Dhoeller19,
kellyguo11,
Mayankm96,
nikitardn and
jtigue-bdai
as code owners
September 20, 2024 08:47
Can I have some guidance on how the test should be completed |
in articulation.py we could set the default_joint_stiffness and default_joint_damping properly , instead of settings all zeros for explicit actuators. this would simplify this PR. ...
set defaults from the sim first
...
for actuator_name, actuator_cfg in self.cfg.actuators.items():
if isinstance(actuator, ImplicitActuator):
self.write_joint_xxx
...
else:
self.write_joint_xxx
...
# over write the defaults we got from the sim with our local data
self._data.default_joint_stiffness[slice(None), actuator.joint_indices] = (
actuator._parse_joint_parameter(actuator.cfg.stiffness, actuator.stiffness)
)
self._data.default_joint_damping[slice(None), actuator.joint_indices] = (
actuator._parse_joint_parameter(actuator.cfg.damping, actuator.damping)
) |
MoreTore
force-pushed
the
explicit-gain-randomization
branch
from
September 20, 2024 13:36
85bd8ae
to
1f1a943
Compare
Added my proposed changes to articulations.py to this PR. |
MoreTore
force-pushed
the
explicit-gain-randomization
branch
from
September 21, 2024 00:49
ce45788
to
8e09244
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves: #1000
resolves: #1011
depends: #1006
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
CONTRIBUTORS.md
or my name already exists thereconfig/extension.toml
file