Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some workflows #3254

Merged
merged 18 commits into from
Dec 9, 2022
Merged

chore: fix some workflows #3254

merged 18 commits into from
Dec 9, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Dec 7, 2022 •
edited
Loading

Only run some workflows if the appropriate files have a diff.

@aljo242 aljo242 added the skip-changelog Don't check changelog for new entries label Dec 7, 2022
@aljo242 aljo242 marked this pull request as ready for review December 7, 2022 18:47
@aljo242
Copy link
Contributor Author

aljo242 commented Dec 7, 2022

@albttx what do you think?

@aljo242 aljo242 requested a review from albttx December 7, 2022 18:47
albttx
albttx requested changes Dec 7, 2022
View reviewed changes
.github/workflows/md-link-checker.yml Outdated Show resolved Hide resolved
.github/workflows/test-integration.yml Show resolved Hide resolved
@tbruyelle
Copy link
Contributor

I would have expected that the related gh test actions would not be executed in this PR, since no go file is modified. True?

@aljo242
Copy link
Contributor Author

aljo242 commented Dec 8, 2022

I would have expected that the related gh test actions would not be executed in this PR, since no go file is modified. True?

So all of the tests are being skipped, but sometimes it is just taking a very long time.

See: https://github.com/ignite/cli/actions/runs/3641926532/jobs/6148443784 for a really bad example.

Most of the time it looks like the integration tests are being skipped in ~2m which is better than running them everytime. I'm not sure why it takes a long time sometimes.

@aljo242 aljo242 mentioned this pull request Dec 8, 2022
Merged
5 tasks
@aljo242 aljo242 requested a review from albttx December 8, 2022 16:16
@aljo242 aljo242 merged commit 597e70f into main Dec 9, 2022
@aljo242 aljo242 deleted the chore/workflows branch December 9, 2022 14:13
@tbruyelle
Copy link
Contributor

The man w/o memory 😭 : I approved this PR while I specifically removed the get-diff 2 months ago, mainly because it was too long on this huge codebase.

#2882

Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
chore: fix some workflows (ignite#3254)
3778b1a 
* add conditions to lint check

* lint

* delete cosmoverse

* conditional

* try integration

* fix

* fix

* attempt test

* integration

* docs deploy

* md-lint fix

* check testdata changes for tests

* remove md-link-checker

* re-add link check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle approved these changes

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@albttx albttx albttx approved these changes

@lumtis lumtis Awaiting requested review from lumtis

@fadeev fadeev Awaiting requested review from fadeev

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees
No one assigned
Labels
skip-changelog Don't check changelog for new entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aljo242 @tbruyelle @jeronimoalbi @albttx