chore: remove get-diff action #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This action has probably been introduced to skip longer action like lint and test when there's no change. Unfortunately now the codebase is too large (probably because of binary files), and the action is now longer than lint and tests. Instead of trying to tune it to skip binary files, this change simply removes it, because lint and test actions aren't that long anyway.
tbruyelle
requested review from
ilgooz,
lumtis,
jeronimoalbi,
aljo242 and
fadeev
as code owners
aljo242
previously approved these changes
Oct 4, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* chore: remove get-diff action This action has probably been introduced to skip longer action like lint and test when there's no change. Unfortunately now the codebase is too large (probably because of binary files), and the action is now longer than lint and tests. Instead of trying to tune it to skip binary files, this change simply removes it, because lint and test actions aren't that long anyway. * oups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action has probably been introduced to skip longer action like lint and test when there's no change. Unfortunately now the codebase is too large (probably because of binary files), and the action is now longer than lint and tests.
Instead of trying to tune it to skip binary files, this change simply removes it, because lint and test actions aren't that long anyway.