Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix name error when accelerate is not available #26278

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix name error when accelerate is not available #26278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31f0c75
fix name error when accelerate is not available
pacman100 Sep 20, 2023
c534c80
fix `is_fsdp_available`
pacman100 Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/utils/import_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ def is_accelerate_available(min_version: str = None):


def is_fsdp_available(min_version: str = "1.12.0"):
return version.parse(_torch_version) >= version.parse(min_version)
return is_torch_available() and version.parse(_torch_version) >= version.parse(min_version)


def is_optimum_available():
Expand Down
1 change: 1 addition & 0 deletions tests/fsdp/test_fsdp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ def get_master_port(real_launcher=False):
# hack to restore original logging level pre #21700
get_regression_trainer = partial(tests.trainer.test_trainer.get_regression_trainer, log_level="info")

require_fsdp_version = require_fsdp
if is_accelerate_available():
from accelerate.utils.constants import (
FSDP_PYTORCH_VERSION,
Expand Down
Loading