Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix name error when accelerate is not available #26278

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Fixes the non-torch test failures ERROR tests/fsdp/test_fsdp.py - NameError: name 'require_fsdp_version' is not defined

@pacman100 pacman100 marked this pull request as ready for review September 20, 2023 05:39
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 20, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix @pacman100 !

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 20, 2023

Merge now to prevent further failure on main

@ydshieh ydshieh merged commit 86ffd5f into main Sep 20, 2023
21 checks passed
@ydshieh ydshieh deleted the smangrul/fsdp-tests-fixes branch September 20, 2023 06:02
@ArthurZucker
Copy link
Collaborator

You should also link the PR that was failing, #26180 if I am not mistaken

parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* fix name error when accelerate is not available

* fix `is_fsdp_available`
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* fix name error when accelerate is not available

* fix `is_fsdp_available`
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* fix name error when accelerate is not available

* fix `is_fsdp_available`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants