Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextServer] Pass Dictionary properties by value and check property values instead of references. #81406

Merged
merged 1 commit into from
Sep 8, 2023
Merged

[TextServer] Pass Dictionary properties by value and check property values instead of references. #81406

merged 1 commit into from
Sep 8, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 7, 2023

  • Since there's no way to track changes in the Dictionary, pass it by value (duplicate).
  • Instead of matching references, match Dictionary fields.

Fixes regression from #79166 (see #81397, it seems like something wrong theme propagation, and it just uncovered excessive theme fonts updates).

@bruvzg bruvzg added this to the 4.2 milestone Sep 7, 2023
@bruvzg bruvzg requested a review from a team as a code owner September 7, 2023 09:03
@akien-mga akien-mga merged commit 31a7fd1 into godotengine:master Sep 8, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus mentioned this pull request Sep 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaosus Chaosus Chaosus approved these changes

Assignees
No one assigned
Labels
bug regression topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @Chaosus