Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zooming in the script editor freezes the editor #81397

Closed
Chaosus opened this issue Sep 7, 2023 · 3 comments
Closed

Zooming in the script editor freezes the editor #81397

Chaosus opened this issue Sep 7, 2023 · 3 comments

Comments

@Chaosus
Copy link
Member

Chaosus commented Sep 7, 2023

Godot version

8449592

System information

Windows 11

Issue description

Zooming in the script editor on an empty script freezes the entire editor for a few seconds, but if the file is large then it freezes for 4-5 seconds (which is unacceptable). Looks like a recent regression.

Steps to reproduce

Just zoom in/out on the large script file.

Minimal reproduction project

N/A

@Chaosus Chaosus added this to the 4.2 milestone Sep 7, 2023
@Chaosus Chaosus changed the title Zooming in the script editor will freeze the editor Zooming in the script editor freezes the editor Sep 7, 2023
@jsjtxietian
Copy link
Contributor

jsjtxietian commented Sep 7, 2023

I run an test with around a gdscript with around 200 lines, zoom in and out for a while, this is intel vtune's report of my test:

image

It seems Control::set_theme is the hotspot here. And the call stack is a little weird, the event propagation seems like wrong...

@bruvzg
Copy link
Member

bruvzg commented Sep 7, 2023

Seems like something is wrong with theme propagation:

Screenshot 2023-09-07 at 10 01 50

But bisects to the #79166 (I guess can be fixed by reintroducing checks as recursive), but theme propagation probably do excessive font updates as well.

@Chaosus
Copy link
Member Author

Chaosus commented Sep 9, 2023

Fixed by #81406

@Chaosus Chaosus closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants