Fix trim when importing WAV #75261
Merged
Fix trim when importing WAV #75261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could someone take a look at this? |
akien-mga
added
cherrypick:3.x
akien-mga
removed
cherrypick:3.x
|
Thanks! |
|
Thank you! |
|
Cherry-picked for 4.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #59170
It seems the trim condition was changed from
!loopto(loop_mode != AudioStreamSample::LOOP_DISABLED)which are oppositeThis also affects 3.x due to backport, and I have a 3.x version of this fix and can open PR for it if this gets accepted and backport is wanted.
Fixes #75236
3.x version: #78048