ResourceImporterWAV: Allow configuring loop mode on import #59170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
edit/loop_mode
import options lets user choose to either:Previously the only options were to import loop points from WAV, or to force a full-length forward loop. There was no easy way to disable looping if it's embedded in the WAV, which confuses many users.
Fixes #46164, at least the most egregious part. The UX around editing loop points on an already imported WAV resource is still awkward.
Notes
3.x
backport, the compatibility should be preserved with the previousedit/loop
boolean option. Could possibly be added in this PR too formaster
if wanted.-1
to select the end frame (and that's the default value for "Loop End").simplescreenrecorder-2022-03-15_16.44.35.mp4