Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clearcoat, anisotropy and refraction in SpatialMaterial in GLES2 #51967

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 21, 2021

Follow-up to #50331.

These SpatialMaterial features work just fine in GLES2, but they were not exposed in the inspector when GLES2 was used.

After merging, remember to update Differences between GLES2 and GLES3 in the documentation.

HTML5 export for testing: https://0x0.st/-yhx.zip (link expires in December 2021)
Unzip the archive, host a local web server from the extracted folder using something like devd then open the web server's homepage in a browser. I can confirm the HTML5 export looks as expected for anisotropy and refraction here.

Preview

Clearcoat

The difference is very subtle, but it's there. This is likely due to #14403. No screenshot for this one, as the difference is barely visible even when looking directly at the specular lobe on the wood material.

Anisotropy

Anisotropy

Refraction

Refractions will always be sharp regardless of material roughness. This is a GLES2 limitation, but the effect may still be enough for many use cases such as heat wave effects using particles.

Refraction

These SpatialMaterial features work just fine in GLES2,
but they were not exposed in the inspector when GLES2 was used.
@Calinou Calinou force-pushed the spatialmaterial-gles2-allow-more-features branch from 5facbbe to 33d2328 Compare August 22, 2021 00:18
@Calinou Calinou requested a review from a team as a code owner August 22, 2021 00:18
@mhilbrunner mhilbrunner merged commit 8c98320 into godotengine:3.x Aug 23, 2021
@mhilbrunner
Copy link
Member

Thank you!

@Calinou Calinou deleted the spatialmaterial-gles2-allow-more-features branch August 23, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants