Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearcoat effect on materials is too subtle #14403

Closed
Tracked by #56333
Calinou opened this issue Dec 8, 2017 · 7 comments
Closed
Tracked by #56333

Clearcoat effect on materials is too subtle #14403

Calinou opened this issue Dec 8, 2017 · 7 comments

Comments

@Calinou
Copy link
Member

Calinou commented Dec 8, 2017

Operating system or device, Godot version, GPU Model and driver (if graphics related): Windows 10, Godot Git 5614902, NVIDIA GeForce GTX 1080

Issue description: The clearcoat effect on materials is too subtle, and isn't noticeable at all on most materials of the Material Testers demo; it's only very slightly noticeable on the "mirror" material. This may hint at a bug in the PBR shader.

Steps to reproduce: Create a SpatialMaterial, enable its Clearcoat property, then play around with the Clearcoat and Gloss values.

@adriansnetlis
Copy link

Yes, I agree that clearcoat doesn't work right.

To me it looks like clearcoat only uses data from light sources and doesn't use reflection map. Clearcoat should also sample reflection map to produce correct results.

@alukreis
Copy link

alukreis commented Sep 18, 2019

Could this be closed given the referenced ticket is closed as fixed?

@Calinou
Copy link
Member Author

Calinou commented Sep 18, 2019

@alukreis I'm not sure if this was fixed, but I noticed it seems to be closer to the intended effect when using a material with roughness set to 0.5. Here's a specular highlight on a material with Clearcoat disabled:

image

And this is the same material with Clearcoat intensity and gloss set to 1:

image

Unlike the highlights created by increasing the Specular intensity, the clearcoat dot is much less "diffuse" over the material.

@reduz I'd like your input on this 🙂 Have any changes been made to Clearcoat in the Vulkan renderer, or is the current approach considered correct?


Edit: reduz told me the Clearcoat property probably doesn't act as intended, but he's not sure if he can fix it right away. He'll put this issue as a "task for grabs" for those looking to improve the Vulkan renderer.

@KoBeWi
Copy link
Member

KoBeWi commented Aug 22, 2020

Looks still valid in 2ba96f0

@toddwong
Copy link

Seems it's been a while. How is it going?

@Calinou
Copy link
Member Author

Calinou commented Apr 21, 2023

Seems fine as of 4.0.2 (left = no clearcoat, right = with clearcoat, using default properties):

image

And in 3.6.beta1 too (this was likely fixed earlier, but I wanted to test with TorusMesh):

image

(The effect appears stronger in 4.0, but the light parameters are different in my test projects.)

Testing projects:

@Calinou Calinou closed this as completed Apr 21, 2023
@Calinou Calinou added this to the 3.5 milestone Apr 21, 2023
@Calinou
Copy link
Member Author

Calinou commented Apr 21, 2023

@toddwong Please don't ask support questions here, as this issue tracker is meant to be used for bug reports only. Use one of the other community channels instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants