Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: payments irrespective of party types (backport #37828) #43040

Open
wants to merge 12 commits into
base: version-14-hotfix
Choose a base branch
from
Open

fix: payments irrespective of party types (backport #37828) #43040

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e5f2f0f
fix: remove validation for negative outstanding invoices
GursheenK Nov 1, 2023
c1f536b
fix: test for invoice returns
GursheenK Nov 2, 2023
70bd372
test: receive payments from payable party
GursheenK Nov 2, 2023
4ab5c59
fix: credit note receive payment entry
GursheenK Nov 3, 2023
2426ddd
test: receive payments from payable party
GursheenK Nov 3, 2023
bdae868
fix: skip check for removed validation
GursheenK Nov 6, 2023
7a34b91
fix: handle gle for standalone credit and debit notes
GursheenK Nov 6, 2023
23960f6
fix: use get_all instead of get_list
GursheenK Nov 8, 2023
e7c7856
refactor: use different GL build logic
dj12djdjs Dec 14, 2023
dc9ef2d
refactor: redefine dr_or_cr for unallocated amount
ruthra-kumar Nov 28, 2023
477b711
fix: indentation error
dj12djdjs Dec 14, 2023
2f2afca
chore: linter
dj12djdjs Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: indentation error 
# Reference: 58114e7
  • Loading branch information
@dj12djdjs
dj12djdjs committed Sep 3, 2024
commit 477b71104dfc34fdde3321a01f5f77c3a7dc1a2f
9 changes: 4 additions & 5 deletions erpnext/accounts/doctype/payment_entry/payment_entry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,13 +1089,12 @@ def add_party_gl_entries(self, gl_entries):

gl_entries.append(gle)

if self.unallocated_amount:
dr_or_cr = "credit" if self.payment_type == "Receive" else "debit"
exchange_rate = self.get_exchange_rate()
base_unallocated_amount = self.unallocated_amount * exchange_rate
if self.unallocated_amount:
dr_or_cr = "credit" if self.payment_type == "Receive" else "debit"
exchange_rate = self.get_exchange_rate()
base_unallocated_amount = self.unallocated_amount * exchange_rate

gle = party_gl_dict.copy()

gle.update(
{
dr_or_cr + "_in_account_currency": self.unallocated_amount,
Expand Down
Loading