-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: payments irrespective of party types (backport #37828) #43040
base: version-14-hotfix
Are you sure you want to change the base?
fix: payments irrespective of party types (backport #37828) #43040
Conversation
# Reference: frappe@58114e7
# Reference: frappe@58114e7
@dj12djdjs did you also consider this follow-up to the original PR? #38071 Also, these validations we're removing in the backend still exist in the frontend, even on the develop branch: erpnext/erpnext/accounts/doctype/payment_entry/payment_entry.js Lines 1089 to 1107 in 0633484
Is this on purpose? |
@barredterra I noticed that, my customer wasn't to picky about it and just ignored the popup. It should be removed from the frontend. Will rebase and remove that logic. |
I didn't want to overwrite the changes in #38630 in case I've made an error during rebase.
continuation of: #38630
backport of: #37828