Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 #299

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Drop support for Python 3.6 #299

merged 5 commits into from
Jan 24, 2022

Conversation

leouieda
Copy link
Member

Update the python_requires field and metadata in setup.cfg. Bump the
minimum version tested on CI to 3.7.

Fixes #285

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

Update the `python_requires` field and metadata in `setup.cfg`. Bump the
minimum version tested on CI to 3.7.
@hugovk
Copy link
Member

hugovk commented Jan 24, 2022

The CI failure looks temporary.

PR looks good, remember to update the min Python version required in doc/install.rst

Running pyupgrade **/*.py --py37-plus (and Black) only suggests this change:

diff --git a/pooch/hashes.py b/pooch/hashes.py
index 77524bc..d487d5f 100644
--- a/pooch/hashes.py
+++ b/pooch/hashes.py
@@ -208,11 +208,9 @@ def make_registry(directory, output, recursive=True):
         pattern = "*"
 
     files = sorted(
-        [
-            str(path.relative_to(directory))
-            for path in directory.glob(pattern)
-            if path.is_file()
-        ]
+        str(path.relative_to(directory))
+        for path in directory.glob(pattern)
+        if path.is_file()
     )
 
     hashes = [file_hash(str(directory / fname)) for fname in files]

@leouieda
Copy link
Member Author

Thanks @hugovk! I had completely forgotten about that 👍🏽 Removed the list creation as well.

@leouieda
Copy link
Member Author

I think the failures are outages on the Zenodo servers. We don't hit their servers very often so it's OK to restart the jobs once in a while when this fails.

@leouieda leouieda merged commit 07336ef into main Jan 24, 2022
@leouieda leouieda deleted the drop3.6 branch January 24, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.6 support
2 participants