Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks: make names more clear #1684

Closed
wants to merge 2 commits into from
Closed

Benchmarks: make names more clear #1684

wants to merge 2 commits into from

Conversation

esantorella
Copy link
Contributor

Summary:
'full_run' -> 'multiple_problems_methods' (problems x methods x seeds)
'test' -> 'one_problem_method' (and multiple seeds)
'replication' -> 'replication' (one problem-method-seed)

Also arc lint

Reviewed By: Balandat

Differential Revision: D46989156

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Jun 23, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46989156

esantorella and others added 2 commits June 23, 2023 15:56
@esantorella @facebook-github-bot
Benchmarks: restore some deleted functionality (facebook#1683)
17f2b98 
Summary:
Pull Request resolved: facebook#1683

Put percentiles back into AggregatedBenchmarkResult since Sait is using them

Differential Revision: https://internalfb.com/D46921900

fbshipit-source-id: e6b07a14cd6f291cc22ac4b4d71219065757c355
@esantorella @facebook-github-bot
Benchmarks: make names more clear (facebook#1684)
6d0fa80 
Summary:
Pull Request resolved: facebook#1684

'full_run' -> 'multiple_problems_methods' (problems x methods x seeds)
'test' -> 'one_problem_method' (and multiple seeds)
'replication' -> 'replication' (one problem-method-seed)

Also `arc lint`

Reviewed By: Balandat

Differential Revision: D46989156

fbshipit-source-id: ef74fc8c2a2a4ac4da3b3c55872d2f1677f6aad9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46989156

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (298df24) 94.96% compared to head (ca51f0f) 94.96%.

❗ Current head ca51f0f differs from pull request most recent head 6d0fa80. Consider uploading reports for the commit 6d0fa80 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1684      +/-   ##
==========================================
- Coverage   94.96%   94.96%   -0.01%     
==========================================
  Files         447      447              
  Lines       41252    41261       +9     
==========================================
+ Hits        39174    39182       +8     
- Misses       2078     2079       +1
Impacted Files Coverage Δ
ax/benchmark/benchmark.py 92.85% <100.00%> (ø)
ax/benchmark/benchmark_result.py 97.82% <100.00%> (+0.20%) ⬆️
ax/benchmark/tests/test_benchmark.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 94363dd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esantorella @facebook-github-bot @codecov-commenter