Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks: restore some deleted functionality #1683

Closed
wants to merge 1 commit into from
Closed

Benchmarks: restore some deleted functionality #1683

wants to merge 1 commit into from

Conversation

esantorella
Copy link
Contributor

Summary: Put percentiles back into AggregatedBenchmarkResult since Sait is using them

Reviewed By: Balandat

Differential Revision: D46921900

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Jun 23, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46921900

esantorella added a commit to esantorella/Ax that referenced this pull request Jun 23, 2023
@esantorella @facebook-github-bot
Benchmarks: restore some deleted functionality (facebook#1683)
17f2b98 
Summary:
Pull Request resolved: facebook#1683

Put percentiles back into AggregatedBenchmarkResult since Sait is using them

Differential Revision: https://internalfb.com/D46921900

fbshipit-source-id: e6b07a14cd6f291cc22ac4b4d71219065757c355
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (298df24) 94.96% compared to head (0f183da) 94.96%.

❗ Current head 0f183da differs from pull request most recent head 0cf6142. Consider uploading reports for the commit 0cf6142 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1683   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         447      447           
  Lines       41252    41261    +9     
=======================================
+ Hits        39174    39183    +9     
  Misses       2078     2078
Impacted Files Coverage Δ
ax/benchmark/benchmark_result.py 97.82% <100.00%> (+0.20%) ⬆️
ax/benchmark/tests/test_benchmark.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@esantorella @facebook-github-bot
Benchmarks: restore some deleted functionality (facebook#1683)
0cf6142 
Summary:
Pull Request resolved: facebook#1683

Put percentiles back into AggregatedBenchmarkResult since Sait is using them

Reviewed By: Balandat

Differential Revision: D46921900

fbshipit-source-id: 581f5b0c3f4368a059528041959052c5455745b7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46921900

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f2aa68e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esantorella @facebook-github-bot @codecov-commenter