-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[balsa] Fix header size limit error messages. #22447
Commits on Jul 28, 2022
-
[balsa] Fix header size limit error messages.
Change error messages for too large headers that match ConnectionImpl::checkMaxHeadersSize() behavior. When http-parser parses a piece of data, it immediately calls ParserCallbacks::onHeaderField() or ParserCallbacks::onHeaderValue() with the current fragment of header key or value, and ConnectionImpl::checkMaxHeadersSize() checks size limit each time. On the other hand, BalsaFrame buffers the header key and value and only calls BalsaVisitorInterface::OnHeader() when the given header completes. In order to prevent from memory attacks, the header size limit is passed to BalsaFrame through BalsaParser constructor, and BalsaFrame internally enforces the limit while parsing. Signed-off-by: Bence Béky <bnc@google.com>
Configuration menu - View commit details
-
Copy full SHA for 70a7724 - Browse repository at this point
Copy the full SHA 70a7724View commit details -
Re-disable Parsers/Http1ServerConnectionImplTest.Utf8Path/BalsaParser.
Signed-off-by: Bence Béky <bnc@google.com>
Configuration menu - View commit details
-
Copy full SHA for 9705041 - Browse repository at this point
Copy the full SHA 9705041View commit details
Commits on Aug 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ecfb2b5 - Browse repository at this point
Copy the full SHA ecfb2b5View commit details -
Merge remote-tracking branch 'upstream/main' into trailers
Signed-off-by: Bence Béky <bnc@google.com>
Configuration menu - View commit details
-
Copy full SHA for 800e313 - Browse repository at this point
Copy the full SHA 800e313View commit details -
Signed-off-by: Bence Béky <bnc@google.com>
Configuration menu - View commit details
-
Copy full SHA for c2fa4b4 - Browse repository at this point
Copy the full SHA c2fa4b4View commit details
Commits on Aug 3, 2022
-
Protect ConnectionImpl::dispatchSlice() behavior change with existing…
… flag. Signed-off-by: Bence Béky <bnc@google.com>
Configuration menu - View commit details
-
Copy full SHA for 877a022 - Browse repository at this point
Copy the full SHA 877a022View commit details
Commits on Aug 5, 2022
-
Merge remote-tracking branch 'upstream/main' into trailers
Signed-off-by: Bence Béky <bnc@google.com>
Configuration menu - View commit details
-
Copy full SHA for ba6edd6 - Browse repository at this point
Copy the full SHA ba6edd6View commit details
Commits on Aug 8, 2022
-
Merge remote-tracking branch 'upstream/main' into trailers
Signed-off-by: Bence Béky <bnc@google.com>
Configuration menu - View commit details
-
Copy full SHA for 8eaa4c3 - Browse repository at this point
Copy the full SHA 8eaa4c3View commit details
Commits on Aug 10, 2022
-
Merge remote-tracking branch 'upstream/main' into trailers
Signed-off-by: Bence Béky <bnc@google.com>
Configuration menu - View commit details
-
Copy full SHA for 9b4e70f - Browse repository at this point
Copy the full SHA 9b4e70fView commit details