Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[balsa] Fix header size limit error messages. #22447

Merged
merged 9 commits into from
Aug 11, 2022
Merged

[balsa] Fix header size limit error messages. #22447

merged 9 commits into from
Aug 11, 2022

Commits on Jul 28, 2022

  1. [balsa] Fix header size limit error messages.

    Change error messages for too large headers that match
    ConnectionImpl::checkMaxHeadersSize() behavior.
    
    When http-parser parses a piece of data, it immediately calls
    ParserCallbacks::onHeaderField() or ParserCallbacks::onHeaderValue()
    with the current fragment of header key or value, and
    ConnectionImpl::checkMaxHeadersSize() checks size limit each time.
    
    On the other hand, BalsaFrame buffers the header key and value and only
    calls BalsaVisitorInterface::OnHeader() when the given header completes.
    In order to prevent from memory attacks, the header size limit is passed
    to BalsaFrame through BalsaParser constructor, and BalsaFrame internally
    enforces the limit while parsing.
    
    Signed-off-by: Bence Béky <bnc@google.com>
    bnc-google committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    70a7724 View commit details
    Browse the repository at this point in the history
  2. Re-disable Parsers/Http1ServerConnectionImplTest.Utf8Path/BalsaParser.

    Signed-off-by: Bence Béky <bnc@google.com>
    bnc-google committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    9705041 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Further improvements.

    Signed-off-by: Bence Béky <bnc@google.com>
    bnc-google committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    ecfb2b5 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/main' into trailers

    Signed-off-by: Bence Béky <bnc@google.com>
    bnc-google committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    800e313 View commit details
    Browse the repository at this point in the history
  3. Re-enable two more tests.

    Signed-off-by: Bence Béky <bnc@google.com>
    bnc-google committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    c2fa4b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Protect ConnectionImpl::dispatchSlice() behavior change with existing…

    … flag.
    
    Signed-off-by: Bence Béky <bnc@google.com>
    bnc-google committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    877a022 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Merge remote-tracking branch 'upstream/main' into trailers

    Signed-off-by: Bence Béky <bnc@google.com>
    bnc-google committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    ba6edd6 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Merge remote-tracking branch 'upstream/main' into trailers

    Signed-off-by: Bence Béky <bnc@google.com>
    bnc-google committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    8eaa4c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Merge remote-tracking branch 'upstream/main' into trailers

    Signed-off-by: Bence Béky <bnc@google.com>
    bnc-google committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    9b4e70f View commit details
    Browse the repository at this point in the history