[balsa] Fix header size limit error messages. #22447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change error messages for too large headers that match ConnectionImpl::checkMaxHeadersSize() behavior. When http-parser parses a piece of data, it immediately calls ParserCallbacks::onHeaderField() or ParserCallbacks::onHeaderValue() with the current fragment of header key or value, and ConnectionImpl::checkMaxHeadersSize() checks size limit each time. On the other hand, BalsaFrame buffers the header key and value and only calls BalsaVisitorInterface::OnHeader() when the given header completes. In order to prevent from memory attacks, the header size limit is passed to BalsaFrame through BalsaParser constructor, and BalsaFrame internally enforces the limit while parsing. Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
diannahu
previously approved these changes
Aug 1, 2022
Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
… flag. Signed-off-by: Bence Béky <bnc@google.com>
diannahu
approved these changes
Aug 3, 2022
Signed-off-by: Bence Béky <bnc@google.com>
|
LGTM |
birenroy
approved these changes
Aug 8, 2022
diannahu
approved these changes
Aug 8, 2022
|
Thank you both for the reviews. |
|
Kevin: PTAL /assign @KBaichoo |
Signed-off-by: Bence Béky <bnc@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
KBaichoo
approved these changes
Aug 9, 2022
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Bence Béky <bnc@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change error messages for too large headers that match
ConnectionImpl::checkMaxHeadersSize() behavior.
When http-parser parses a piece of data, it immediately calls
ParserCallbacks::onHeaderField() or ParserCallbacks::onHeaderValue()
with the current fragment of header key or value, and
ConnectionImpl::checkMaxHeadersSize() checks size limit each time.
On the other hand, BalsaFrame buffers the header key and value and only
calls BalsaVisitorInterface::OnHeader() when the given header completes.
In order to prevent from memory attacks, the header size limit is passed
to BalsaFrame through BalsaParser constructor, and BalsaFrame internally
enforces the limit while parsing.
Tracking issue: #21245
Signed-off-by: Bence Béky bnc@google.com
Commit Message: [balsa] Fix header size limit error messages.
Additional Description: n/a
Risk Level: low, BalsaParser is behind default-false flag
Testing: //test/common/http/http1:codec_impl_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a