Remove Ember.Map, Ember.MapWithDefault and Ember.OrderedSet #237
Conversation
text/0000-deprecation-ember-map.md
Outdated
|
|
||
| # Transition Path | ||
|
|
||
| The classes will be extracted to an addon and the ones in Ember will be deprecated. |
There was a problem hiding this comment.
what are the details on how ember-data will work, and how we can be backwards compat with ED. It's possible, but that needs to be fleshed out in this RFV
There was a problem hiding this comment.
If that is in the scope of this RFC, it might be worthwhile to take a look at switching to the native ES6 Map. The MapWithDefault behavior can be easily achieved: Babel REPL PoC
I would be available for such a PR in Ember Data. 🙋♂️
There was a problem hiding this comment.
@buschtoens I don't think it is. Switching to native Map seems like a big undertaking, especially if we are to support IE9 and family :P
|
|
||
| # Drawbacks | ||
|
|
||
| This requires cooperation with Ember Data, the main user of these classes. It would be nice to have moved Ember Data to using the addon before releasing Ember with the deprecation so the average user does not see any deprecation warning. |
There was a problem hiding this comment.
👍 for this option. I recall the last time something in heavy use in Ember Data was deprecated I was hit with a terrifying number of notices that I could do nothing about. While methods now exist to hep with this it should still be avoided if possible.
locks
changed the title
|
I'd like to see this one start to gain traction now that 3.0 is "out the door". @Serabe - Thanks for the recent round of updates! I think the task list in the transition path looks pretty close to what I was thinking, but I'd like to make it clearer that the deprecation would only be landed once a released version of ember-data that included the fixes (to prevent the deprecation) shipped. Do you think that is clear enough in the current prose? |
|
Changes landed in ember-data to remove direct usage of these classes:
Both of those PR's should wind up included in ember-data@3.1. |
|
Just discussed this with the rest of the core team, and with the recent round of changes and the work in ember-data to detangle from these classes we think this is ready for final comment period. |
|
Lets do it! |
rendered