[BUGFIX release] Fixes isEmpty for non-Ember.Map object with size property
#14928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith `size` property Fixes #14884
| @@ -39,7 +40,7 @@ export default function isEmpty(obj) { | |||
|
|
|||
| let objectType = typeof obj; | |||
|
|
|||
| if (objectType === 'object') { | |||
| if (objectType instanceof EmberMap) { | |||
There was a problem hiding this comment.
not sure if this matters, but this would not work if 2 embers where present on the same page. As there would be two different EmberMap and the isEmpty of one, could not work with the other.
There was a problem hiding this comment.
The fix for this, would be to add some property to EmberMap that we can check (e.g. obj.isEmberMap or obj[SOME_PRIVATE_EMBER_MAP_SYMBOL_THINGY] depending on how paranoid we want to be)...
There was a problem hiding this comment.
Sorry for letting this slide. What's the call here? Will investigate CI failure.
There was a problem hiding this comment.
@lock I think the private, non-enumerable symbol would be the correct path.
|
Close due to emberjs/rfcs#237. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14884
Relevant context: #9414