[BUGFIX release] Ensure that multiple app event dispatching works properly. #11290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
ensure-multiple-apps-work
branch
2 times, most recently
from
4738731
to
875f9bb
Compare
rwjblue
force-pushed
the
ensure-multiple-apps-work
branch
from
875f9bb
to
d6ae292
Compare
rwjblue
added a commit
that referenced
this pull request
May 28, 2015
[BUGFIX release] Ensure that multiple app event dispatching works properly.
|
Thanks for taking the time to fix this, @rwjblue! |
|
👍 -- I just ran into this bug with 1.12.1 - Any word on when a patch might release? |
|
You can use the latest build in the release channel now, but a 1.12.2 will likely be released sometime before Friday. |
|
Thanks for the quick response - I can wait until a 1.12.2... I added a |
|
Hmm, looks like this didn't make it into 1.13.0, either. Will it be in 1.13.1? |
rwjblue
added a commit
to rwjblue/ember-test-helpers
that referenced
this pull request
Jul 30, 2015
In Ember 1.12.0 and 1.12.1 the `-view-registry:main` was introduced as a mechanism to track views without mutating the global `Ember.View.views` registry (needed for fastboot work), unfortunately the `Ember.EventDispatcher` was not updated to use the new view registry and therefore any views added in a view registry other than `Ember.View.views` will not be able to handle DOM events. The event dispatcher was fixed in emberjs/ember.js#11290. This change ensures that `-view-registry:main` is the same as `Ember.View.views` on Ember versions where `Ember.View.views` exists (Ember < 1.13.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11195.