[BUGFIX beta] Ensure view registry is provided to components. #11270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
added a commit
that referenced
this pull request
May 25, 2015
…-down [BUGFIX beta] Ensure view registry is provided to components.
|
|
||
| runAppend(view); | ||
|
|
||
| equal(innerTemplate._viewRegistry, viewRegistry); |
There was a problem hiding this comment.
should this also test that w/e uses viewRegistry works correctly?
There was a problem hiding this comment.
By default _viewRegistry is Ember.View.views, but that does not work in the fastboot or multiple app scenario (because there are two different view registries).
This change, ensures that the _viewRegistry is passed down through the various views/components created during render (it was previously not passed through). It does not actually test that things use _viewRegistry (though they should).
There was a problem hiding this comment.
@stefanpenner - Thanks for poking me into looking into the usage side of this, #11290 fixes an issue with the event dispatcher that broke multiple apps on the page...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.