Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v95.10.1 #192026

Merged
merged 22 commits into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a8bc292
Upgrade EUI to v95.10.0
cee-chen Sep 3, 2024
5f32b61
i18n updates
cee-chen Sep 3, 2024
748841f
Fix failing kbn-unified-data-table tests
cee-chen Sep 3, 2024
c0be188
Fix several test console errors/warnings
cee-chen Sep 3, 2024
567e25a
Fix other Jest tests toggling column actions to use data-test-subj in…
cee-chen Sep 3, 2024
a3cdd75
[FTR] Fix tests to account for DOM changes
cee-chen Sep 3, 2024
16ab7e2
[FTR] Fix EuiDataGrid service to account for interactive headers/acti…
cee-chen Sep 3, 2024
6c4941f
[FTR] Fix failing Observability tests to use dataGrid service that ac…
cee-chen Sep 3, 2024
f8d5c8f
[FTR] Fix failing tests to with new dataGrid service that allows clic…
cee-chen Sep 3, 2024
95ac4da
[FTR]: update getHeaderFields selector
mgadewoll Sep 4, 2024
9778711
[FTR]: update lense page changeTableSortingBy hover position to ensur…
mgadewoll Sep 4, 2024
b2f287f
[FTR]: update DataGrid service selectors
mgadewoll Sep 4, 2024
440c5df
chore: cleanup unsed var
mgadewoll Sep 4, 2024
4fc8437
[FTR]: revert table reference in DataGrid service getHeaderFields
mgadewoll Sep 4, 2024
5d9970e
[FTR]: update test order
mgadewoll Sep 4, 2024
bb1a9e0
Patch v95.10.1
cee-chen Sep 4, 2024
f81a10b
Merge remote-tracking branch 'upstream/main' into eui/v95.10.0
cee-chen Sep 4, 2024
8c8ed9a
Simplify test selector
cee-chen Sep 4, 2024
c31a4b1
Merge branch 'main' into eui/v95.10.0
cee-chen Sep 6, 2024
be86345
Merge branch 'main' into eui/v95.10.0
cee-chen Sep 9, 2024
b588c3e
Merge remote-tracking branch 'upstream/main' into eui/v95.10.0
cee-chen Sep 10, 2024
68bfbc2
fix type failure
cee-chen Sep 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[FTR]: revert table reference in DataGrid service getHeaderFields
ensures test order instead, as opened flyout contains a standalone datagrid the column header test assertion should happen on a state with only the first datagrid
  • Loading branch information
mgadewoll committed Sep 4, 2024
commit 4fc8437c91d5a0ff02739891e542e527bc87cc94
10 changes: 5 additions & 5 deletions test/functional/apps/context/_discover_navigation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({});
});

it('should open the context view with the same columns', async () => {
const columnNames = await dataGrid.getHeaderFields();
expect(columnNames).to.eql(['@timestamp', ...TEST_COLUMN_NAMES]);
});

it('should open the context view with the selected document as anchor and allows selecting next anchor', async () => {
/**
* Helper function to get the first timestamp of the document table
Expand Down Expand Up @@ -94,11 +99,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});

it('should open the context view with the same columns', async () => {
const columnNames = await dataGrid.getHeaderFields();
expect(columnNames).to.eql(['@timestamp', ...TEST_COLUMN_NAMES]);
});

it('should open the context view with the filters disabled', async () => {
let disabledFilterCounter = 0;
for (const [columnName, value] of TEST_FILTER_COLUMN_NAMES) {
Expand Down
3 changes: 1 addition & 2 deletions test/functional/services/data_grid.ts
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,7 @@ export class DataGridService extends FtrService {
}

public async getHeaderFields(): Promise<string[]> {
const table = await this.find.byCssSelector('.euiDataGrid');
const result = await table.findAllByCssSelector(
const result = await this.find.allByCssSelector(
'.euiDataGridHeaderCell:not(.euiDataGridHeaderCell--controlColumn) .euiDataGridHeaderCell__content'
);

Expand Down