Upgrade EUI to v95.10.1 #192026

cee-chen · 2024-09-03T18:29:50Z

v95.9.0⏩v95.10.1

Note

EuiDataGrid's header cells have received a major UX change in order to support interactive children within header content. Column header actions now must be hovered and then clicked directly, or opened with the Enter key, as opposed to being able to click the entire header cell to see the actions popover.

Questions? Please see our Kibana upgrade FAQ.

`v95.10.0`

Updated EuiDataGrid to support interactive header cell content (#7898)
Updated EuiSearchBar's field_value_selection filter type with a new autoSortOptions config, allowing consumers to configure whether or not selected options are automatically sorted to the top of the filter list (#7958)
Updated getDefaultEuiMarkdownPlugins to support the following new default plugin configurations: (#7985)
- parsingConfig.linkValidator, which allows configuring allowRelative and allowProtocols
- parsingConfig.emoji, which allows configuring emoticon parsing
- processingConfig.linkProps, which allows configuring rendered links with any props that EuiLink accepts
- See our Markdown plugins documentation for example EuiMarkdownFormat and EuiMarkdownEditor usage
Updated EuiDatePicker to support append and prepend nodes in its form control layout (#7987)

Bug fixes

Fixed border rendering bug with inline EuiDatePickers with shadow={false} (#7987)
Fixed EuiSuperSelect's placeholder text color to match other form controls (#7995)

Accessibility

Improved the keyboard navigation and screen reader output for EuiDataGrid header cells (#7898)

`v95.10.1`

Bug fixes

Fixed a visual bug in compact density EuiDataGrids, where the header cell height would increase when the actions button became visible (#7999)

- not all of them, just the oens related to header column actions in this PR. someone on the owning Kibana team should likely look into resolving all of them - errors were `Warning: An update to DataTable inside a test was not wrapped in act(...).` and `Warning: Can't perform a React state update on an unmounted component`

…stead of text

…ons button changes + fix misc failing test to use said service

…counts for header changes + add new util for default "Hide columns" copy

…king any action at an index + add new util for default "Hide columns" copy

…e mouse is inside header column

ensures test order instead, as opened flyout contains a standalone datagrid the column header test assertion should happen on a state with only the first datagrid

test/functional/services/data_grid.ts

elasticmachine · 2024-09-04T20:39:39Z

Pinging @elastic/eui-team (EUI)

kdelemme

obs-ux-management code change looks good to me!

markov00

Code review and visual check, good for me

davismcphee

Data Discovery changes look good, and everything seems to be working as expected in Discover 👍 Thanks for making the data grid header change, this unblocks some planned changes for us!

cee-chen · 2024-09-09T15:52:57Z

@elastic/kibana-core @elastic/security-threat-hunting-investigations Ping for codeowning review - we will be requesting an admin merge by today or tomorrow.

kibana-ci · 2024-09-10T18:42:42Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 68bfbc2
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-192026-68bfbc297332

Failed CI Steps

Jest Tests #5

Test Failures

[job] [logs] Jest Tests #5 / FormBasedDimensionEditor should list all field names and document as a whole in prioritized order

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	418.2KB	418.6KB	+393.0B
`kbnUiSharedDeps-css`	147.6KB	148.7KB	+1.1KB
`kbnUiSharedDeps-npmDll`	6.2MB	6.2MB	+2.1KB
total			+3.7KB

History

💔 Build #233187 failed b588c3e
💚 Build #232828 succeeded be86345
💔 Build #232557 failed c31a4b1
💚 Build #232063 succeeded 8c8ed9a
💚 Build #232032 succeeded 5d9970e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

`v95.9.0`⏩`v95.10.1` > [!note] > **EuiDataGrid**'s header cells have received a major UX change in order to support interactive children within header content. Column header actions now must be hovered and then clicked directly, or opened with the Enter key, as opposed to being able to click the entire header cell to see the actions popover. _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.10.0`](https://github.com/elastic/eui/releases/v95.10.0) - Updated `EuiDataGrid` to support interactive header cell content ([elastic#7898](elastic/eui#7898)) - Updated `EuiSearchBar`'s `field_value_selection` filter type with a new `autoSortOptions` config, allowing consumers to configure whether or not selected options are automatically sorted to the top of the filter list ([elastic#7958](elastic/eui#7958)) - Updated `getDefaultEuiMarkdownPlugins` to support the following new default plugin configurations: ([elastic#7985](elastic/eui#7985)) - `parsingConfig.linkValidator`, which allows configuring `allowRelative` and `allowProtocols` - `parsingConfig.emoji`, which allows configuring emoticon parsing - `processingConfig.linkProps`, which allows configuring rendered links with any props that `EuiLink` accepts - See our **Markdown plugins** documentation for example `EuiMarkdownFormat` and `EuiMarkdownEditor` usage - Updated `EuiDatePicker` to support `append` and `prepend` nodes in its form control layout ([elastic#7987](elastic/eui#7987)) **Bug fixes** - Fixed border rendering bug with inline `EuiDatePicker`s with `shadow={false}` ([elastic#7987](elastic/eui#7987)) - Fixed `EuiSuperSelect`'s placeholder text color to match other form controls ([elastic#7995](elastic/eui#7995)) **Accessibility** - Improved the keyboard navigation and screen reader output for `EuiDataGrid` header cells ([elastic#7898](elastic/eui#7898)) ## [`v95.10.1`](https://github.com/elastic/eui/releases/v95.10.1) **Bug fixes** - Fixed a visual bug in compact density `EuiDataGrid`s, where the header cell height would increase when the actions button became visible ([elastic#7999](elastic/eui#7999)) --------- Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>

cee-chen added 2 commits September 3, 2024 11:13

Upgrade EUI to v95.10.0

a8bc292

i18n updates

5f32b61

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.16.0 labels Sep 3, 2024

cee-chen and others added 13 commits September 3, 2024 14:18

Fix failing kbn-unified-data-table tests

748841f

Fix other Jest tests toggling column actions to use data-test-subj in…

567e25a

…stead of text

[FTR] Fix tests to account for DOM changes

a3cdd75

[FTR] Fix EuiDataGrid service to account for interactive headers/acti…

16ab7e2

…ons button changes + fix misc failing test to use said service

[FTR] Fix failing Observability tests to use dataGrid service that ac…

6c4941f

…counts for header changes + add new util for default "Hide columns" copy

[FTR] Fix failing tests to with new dataGrid service that allows clic…

f8d5c8f

…king any action at an index + add new util for default "Hide columns" copy

[FTR]: update getHeaderFields selector

95ac4da

[FTR]: update lense page changeTableSortingBy hover position to ensur…

9778711

…e mouse is inside header column

[FTR]: update DataGrid service selectors

b2f287f

chore: cleanup unsed var

440c5df

[FTR]: revert table reference in DataGrid service getHeaderFields

4fc8437

ensures test order instead, as opened flyout contains a standalone datagrid the column header test assertion should happen on a state with only the first datagrid

[FTR]: update test order

5d9970e

cee-chen changed the title ~~Upgrade EUI to v95.10.0~~ Upgrade EUI to v95.10.1 Sep 4, 2024

cee-chen added 2 commits September 4, 2024 09:36

Patch v95.10.1

bb1a9e0

Merge remote-tracking branch 'upstream/main' into eui/v95.10.0

f81a10b

cee-chen commented Sep 4, 2024

View reviewed changes

test/functional/services/data_grid.ts Outdated Show resolved Hide resolved

Simplify test selector

8c8ed9a

cee-chen marked this pull request as ready for review September 4, 2024 20:39

cee-chen requested review from a team as code owners September 4, 2024 20:39

jbudz approved these changes Sep 4, 2024

View reviewed changes

botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 4, 2024

kdelemme approved these changes Sep 5, 2024

View reviewed changes

markov00 approved these changes Sep 6, 2024

View reviewed changes

mgadewoll mentioned this pull request Sep 6, 2024

[DRAFT] button variants testing branch #192280

Draft

Merge branch 'main' into eui/v95.10.0

c31a4b1

davismcphee approved these changes Sep 9, 2024

View reviewed changes

Merge branch 'main' into eui/v95.10.0

be86345

cee-chen added 2 commits September 10, 2024 09:44

Merge remote-tracking branch 'upstream/main' into eui/v95.10.0

b588c3e

fix type failure

68bfbc2

jbudz merged commit 20566d0 into elastic:main Sep 10, 2024
39 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Sep 10, 2024

cee-chen deleted the eui/v95.10.0 branch September 10, 2024 21:18

szaffarano mentioned this pull request Sep 13, 2024

[Telemetry][Security Solution] Fix integration tests on branch 9.0 #192842

Merged

1 task

cee-chen mentioned this pull request Sep 20, 2024

Upgrade EUI to v95.11.0 #192756

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v95.10.1 #192026

Upgrade EUI to v95.10.1 #192026

cee-chen commented Sep 3, 2024 •

edited

Loading

elasticmachine commented Sep 4, 2024

kdelemme left a comment

markov00 left a comment •

edited

Loading

davismcphee left a comment

cee-chen commented Sep 9, 2024

kibana-ci commented Sep 10, 2024 •

edited

Loading

Upgrade EUI to v95.10.1 #192026

Upgrade EUI to v95.10.1 #192026

Conversation

cee-chen commented Sep 3, 2024 • edited Loading

v95.10.0

v95.10.1

elasticmachine commented Sep 4, 2024

kdelemme left a comment

Choose a reason for hiding this comment

markov00 left a comment • edited Loading

Choose a reason for hiding this comment

davismcphee left a comment

Choose a reason for hiding this comment

cee-chen commented Sep 9, 2024

kibana-ci commented Sep 10, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Page load bundle

History

cee-chen commented Sep 3, 2024 •

edited

Loading

`v95.10.0`

`v95.10.1`

markov00 left a comment •

edited

Loading

kibana-ci commented Sep 10, 2024 •

edited

Loading