Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Search assistant plugin setup #190633

Merged
merged 23 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7cc83b4
introduce search assistant plugin
saarikabhasi Aug 15, 2024
ccc6d76
fix CI
saarikabhasi Aug 15, 2024
c09aba6
add review feedback
saarikabhasi Aug 19, 2024
b3f37bc
remove eslint file
saarikabhasi Aug 19, 2024
2fa24a4
fix eslint, add license
saarikabhasi Aug 19, 2024
2077a77
Merge branch 'main' into search-ai-assistant-plugin
elasticmachine Aug 19, 2024
07b7067
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Aug 19, 2024
1762523
add config for FTR
saarikabhasi Aug 19, 2024
0bbf057
Merge branch 'search-ai-assistant-plugin' of github.com:saarikabhasi/…
saarikabhasi Aug 19, 2024
940fa7c
clean files in server folder
saarikabhasi Aug 20, 2024
4d9af48
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Aug 20, 2024
22aff35
remove kibanaReact from kibana.jsonc
saarikabhasi Aug 20, 2024
3adcb0e
Merge branch 'search-ai-assistant-plugin' of github.com:saarikabhasi/…
saarikabhasi Aug 20, 2024
13b9cb1
add index.ts to server/ folder
saarikabhasi Aug 21, 2024
0cab2c2
Update plugin-list.asciidoc
saarikabhasi Aug 21, 2024
165936a
Update README.md
saarikabhasi Aug 21, 2024
6222df9
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
kibanamachine Aug 21, 2024
22336ef
remove ui config from rendering.ts
saarikabhasi Aug 21, 2024
de3cb3c
Merge branch 'main' into search-ai-assistant-plugin
elasticmachine Aug 21, 2024
19eb409
Disable plugin by default
sphilipse Aug 22, 2024
7f17d49
Disable plugin by default
sphilipse Aug 22, 2024
5a5dc83
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Aug 22, 2024
ad2a81a
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
kibanamachine Aug 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean files in server folder
  • Loading branch information
saarikabhasi committed Aug 20, 2024
commit 940fa7ccadcde0a5194c8dd55f60c64a2a21f354
20 changes: 1 addition & 19 deletions x-pack/plugins/search_assistant/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,37 +5,19 @@
* 2.0.
*/

import { i18n } from '@kbn/i18n';
import type { AppMountParameters, CoreSetup, Plugin } from '@kbn/core/public';
import type { CoreSetup, Plugin } from '@kbn/core/public';
import type {
SearchAssistantPluginSetup,
SearchAssistantPluginStart,
SearchAssistantPluginStartDependencies,
} from './types';
import { PLUGIN_ID } from '../common';

export class SearchAssistantPlugin
implements Plugin<SearchAssistantPluginSetup, SearchAssistantPluginStart>
{
public setup(
core: CoreSetup<SearchAssistantPluginStartDependencies, SearchAssistantPluginStart>
): SearchAssistantPluginSetup {
core.application.register({
id: PLUGIN_ID,
appRoute: '/app/search_assistant',
title: i18n.translate('xpack.searchAssistant.applicationTitle', {
defaultMessage: 'Search Assistant',
}),
async mount({ element, history }: AppMountParameters) {
const { renderApp } = await import('./application');
const [coreStart, depsStart] = await core.getStartServices();
const startDeps: SearchAssistantPluginStartDependencies = {
...depsStart,
history,
};
return renderApp(coreStart, startDeps, element);
},
});
return {};
}

Expand Down
15 changes: 0 additions & 15 deletions x-pack/plugins/search_assistant/server/index.ts

This file was deleted.

26 changes: 4 additions & 22 deletions x-pack/plugins/search_assistant/server/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,38 +5,20 @@
* 2.0.
*/

import type {
PluginInitializerContext,
CoreSetup,
CoreStart,
Plugin,
Logger,
} from '@kbn/core/server';
import type { Plugin } from '@kbn/core/server';

import type { SearchAssistantPluginSetup, SearchAssistantPluginStart } from './types';
import { defineRoutes } from './routes';

export class SearchAssistantPlugin
implements Plugin<SearchAssistantPluginSetup, SearchAssistantPluginStart>
{
private readonly logger: Logger;

constructor(initializerContext: PluginInitializerContext) {
this.logger = initializerContext.logger.get();
}

public setup(core: CoreSetup) {
this.logger.debug('SearchAssistant: Setup');
const router = core.http.createRouter();

// Register server side APIs
defineRoutes(router);
constructor() {}

public setup() {
return {};
}

public start(core: CoreStart) {
this.logger.debug('SearchAssistant: Started');
public start() {
return {};
}

Expand Down
24 changes: 0 additions & 24 deletions x-pack/plugins/search_assistant/server/routes/index.ts

This file was deleted.