-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Search assistant plugin setup #190633
[Search] Search assistant plugin setup #190633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed CSS changes on behalf of kibana-design; added a file
f42fdc0
to
ccc6d76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/kbn-optimizer/limits.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Saarika! I left a few comments to clean up, there's some stuff in here that doesn't need to be there (yet), but if we delete that we can merge this.
@elasticmachine merge upstream |
d7c1694
to
2fa24a4
Compare
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unable to start Kibana from this PR.
Error: Cannot find module '/x-pack/plugins/search_assistant/server'
Am I perhaps missing part of the plugin build process?
Some other basic questions:
- What is the purpose of the plugin? As a future extension to the Observability Assistant plugin, what will it add?
- Who will be able to access this plugin? What privileges are required?
- This plugin is currently empty, but if there are plans to introduce HTTP API endpoints, loggers, API keys, or Saved Objects, please consider the appropriate security measures (validation, privileges, logging level, any sensitive information).
Yeah we're missing
We're building a Search-specific assistant that will run in ES3 and Search. It'll have different system prompts, different functions and different quick prompts at minimum, and likely different other extensions over time. But we want to share as much as possible of the backend and components with the Observability AI Assistant. Next steps would be:
TBD, I want to keep that out of this PR for now. There's a lot we still need to decide on and this is just an initial starting point.
Yup, will do. Out of scope for this PR. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the details @sphilipse and updates @saarikabhasi! Unless I am missing something, the plugin appears to be enabled by default. There was a xpack.searchAssistant.ui.enabled
setting, but that did not allow me to disable the pluigin. Additionally, it looks like that setting was removed.
Happy to approve once the plugin is disabled by default for all offerings. This will ensure that main is in a releasable state for serverless.
Done in 7f17d49 @jeramysoucy |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Introducing new plugin for search assistant. in the future this will be extension of Observability AI solution solution plugin
Checklist
Delete any items that are not applicable to this PR.