Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JetBrains PhpStorm stubs to 2021.1 #4694

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 28, 2021

Q A
Type improvement
BC Break no
  1. Replace microsoft/mssql-server-linux:2017-latest in CI configuration with mcr.microsoft.com/mssql/server:2017-latest. Unrelated but necessary for the build to pass. Otherwise, it fails as:
    $ docker pull microsoft/mssql-server-linux:2019-latest
    Error response from daemon: manifest for microsoft/mssql-server-linux:2019-latest not found: manifest unknown: manifest unknown
  2. Use PHP 8 for static analysis. The new version of stubs uses multi-line annotations which PHP 7.4 cannot parse. This may be by design (Avoid using multi-line annotations for PHP 7 compatibility JetBrains/phpstorm-stubs#1160).
  3. Switch from the Psalm GitHub action to a generic implementation since there's no Psalm image built on top of PHP 8 (Update to use PHP 8 psalm/psalm-github-actions#31).

@morozov morozov added this to the 2.13.3 milestone Jun 28, 2021
@morozov morozov force-pushed the phpstorm-stubs-2021.1 branch 3 times, most recently from 1c16a6b to 3062d8e Compare June 28, 2021 21:08
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch from the Psalm GitHub action to a generic implementation since there's no Psalm image built on top of PHP 8

IMO this is better anyway: having a version number in the CI and one in composer.json is asking for trouble.

@morozov
Copy link
Member Author

morozov commented Jun 29, 2021

IMO this is better anyway: having a version number in the CI and one in composer.json is asking for trouble.

Let's keep it this way then. The generic configuration is pretty much straightforward and we use the same one for PHPUnit, PHPStan, and other tools anyways.

@morozov morozov merged commit 4a0798f into doctrine:2.13.x Jun 29, 2021
@morozov morozov deleted the phpstorm-stubs-2021.1 branch June 29, 2021 18:21
@morozov morozov mentioned this pull request Jun 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants