Create tables with unique constraints on PostgreSQL #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Jun 27, 2021
hschletz
force-pushed
the
create-unique-constraints-with-table-postqresql
branch
from
49e4a1b
to
7c226f4
Compare
|
The SQL Server build failure should be fixed after merging and up-merging #4694. Otherwise, looks good. |
PostgreSQL94Platform::_getCreateTableSQL() ignored unique constraints. Implementations for other platforms are OK.
morozov
force-pushed
the
create-unique-constraints-with-table-postqresql
branch
from
7c226f4
to
998284f
Compare
morozov
approved these changes
Jun 29, 2021
|
Thanks, @hschletz. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PostgreSQL94Platform::_getCreateTableSQL() ignored unique constraints.
Implementations for other platforms are OK.