Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language fixes #1769

Merged
merged 7 commits into from
Jun 29, 2020
Merged

Language fixes #1769

merged 7 commits into from
Jun 29, 2020

Conversation

Simon-Laux
Copy link
Member

Please review this carefully this could produce some crashes, I did my best to review it myself but more eyes would be better.
Also best reviewed commit by commit and using the github feature for marking already reviewed files.

to detect and react to language change (fixes #1637)
also fix #1720 because I spontanely found the solution Timestamp.tsx#L44
about the translation system
@Simon-Laux Simon-Laux added the bug Something isn't working label Jun 28, 2020
@Jikstra Jikstra merged commit 47ee3b9 into master Jun 29, 2020
@Jikstra Jikstra deleted the language_fixes branch June 29, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants