Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization fails #1765

Closed
gerryfrancis opened this issue Jun 27, 2020 · 12 comments · Fixed by #1785
Closed

Localization fails #1765

gerryfrancis opened this issue Jun 27, 2020 · 12 comments · Fixed by #1785
Assignees
Labels
bug Something isn't working translations
Milestone

Comments

@gerryfrancis
Copy link
Contributor

gerryfrancis commented Jun 27, 2020

  • Operating System (Linux/Mac/Windows/iOS/Android):
    Windows 8.1 Pro.

  • Delta Chat Version:
    1.4.2 & 1.4.3.

  • Expected behavior:
    Delta Chat starts with the standard language of the operating system. (My system has German installed as standard.)

  • Actual behavior:
    Delta Chat starts with two different languages, German for the mehu bar, and English for the rest.

  • Steps to reproduce the problem:
    -- Set another language (e.g. German) as standard in your operating system.
    -- Install Delta Chat.

  • Screenshots:
    grafik

  • Logs:

2020-06-27T13:28:23.786Z	main/index            	INFO		"cwd C:\\Users\\PC_USER\\AppData\\Local\\DeltaChat"
2020-06-27T13:28:23.886Z	main/menu             	INFO		"rebuilding menu with locale de"
2020-06-27T13:28:29.181Z	main/state            	INFO		"Saving state to C:\\Users\\PC_USER\\AppData\\Local\\DeltaChat\\config.json"
@gerryfrancis gerryfrancis added the bug Something isn't working label Jun 27, 2020
@Simon-Laux
Copy link
Member

Simon-Laux commented Jun 27, 2020

I can reproduce it on linux as well: select a language other than english, restart deltachat and now the menu is in the choosen language, but the interface is english again

@gerryfrancis
Copy link
Contributor Author

@Simon-Laux Maybe related to #1637 ?

@gerryfrancis gerryfrancis changed the title Localization fails (after install from scratch) Localization fails Jun 27, 2020
@Simon-Laux Simon-Laux self-assigned this Jun 27, 2020
@gerryfrancis
Copy link
Contributor Author

Thanks, I will test the fix in the upcoming release! 👍

@gerryfrancis
Copy link
Contributor Author

Unfortunately it is still an issue in version 1.4.3 (German menu bar and English window content like shown in the screenshot above).

@Simon-Laux
Copy link
Member

looks like it appeared again when restarting

@Simon-Laux Simon-Laux reopened this Jul 6, 2020
@gerryfrancis
Copy link
Contributor Author

gerryfrancis commented Jul 6, 2020

looks like it appeared again when restarting

@Simon-Laux It seems that it appears from the very beginning where no language has been set, yet. (BTW, thanks for reopening!)

@Simon-Laux Simon-Laux added this to the 1.5 milestone Jul 8, 2020
@Simon-Laux
Copy link
Member

1.4.2 has that bug, 1.4.3 doesn't have it for me. I can not test the beginning stuff right now because my OS language is en

@gerryfrancis
Copy link
Contributor Author

@Simon-Laux AFAIK, a one-for-all default system language in Windows does not exist anymore, except for the installation process. Actually it is all about the display language that a user prefers. If there are different language packs installed, a user can choose the appropriate language to be a display language. This can be changed quite easily, so there is no need to install another Windows OS in a different language.

@Simon-Laux
Copy link
Member

Simon-Laux commented Jul 10, 2020

I'm on linux...
On windows it doesn't pick up the system language on first start you say? that would then reopen #1751
But I reopened this mainly because @Jikstra had the bug where the app is only partially translated on start, but when changing the lang everything worked as expected until the app was restarted.

@gerryfrancis
Copy link
Contributor Author

gerryfrancis commented Jul 10, 2020

the app is only partially translated on start,

@Simon-Laux Correct, just as I described. (See above.)

but when changing the lang everything worked as expected until the app was restarted.

@Simon-Laux On my machine (Windows 8.1 Pro), when changing the language (first to English because of the menu bar, and then to German), then quitting, and running Delta Chat again, this works. So, this bug is true just for the very beginning where Delta Chat has been installed from scratch.

@gerryfrancis
Copy link
Contributor Author

gerryfrancis commented Jul 10, 2020

On windows it doesn't pick up the system language on first start you say? that would then reopen #1751

@Simon-Laux That has been a fix for #1712 , which, obviously, is right, because the correct language is used for the menu bar. (See screenshot above.) So, I would not reopen #1751 .

@gerryfrancis
Copy link
Contributor Author

@Simon-Laux I have tested in version 1.10.0 and now it works, great! Thanks a lot! 👍

@r10s r10s added bug Something isn't working and removed bug Something isn't working labels Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working translations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants