Scatter plot titles #1200
Closed
Scatter plot titles #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonwoodhull
added a commit
that referenced
this pull request
Dec 23, 2016
gordonwoodhull
added a commit
that referenced
this pull request
Dec 23, 2016
and rename it so it's not clashing with the option and perhaps more consistent with some imagined consistency for #1200
gordonwoodhull
added a commit
that referenced
this pull request
Dec 23, 2016
gordonwoodhull
added a commit
that referenced
this pull request
Dec 23, 2016
the scatter-series one i understand - we have to prevent the composite chart from overriding the title function, since we need the special title function that overrides the grotesque #702 scatter override of key+value accessors but i can't get why we don't need that for the multi-scatter example. they're both composite charts, but this one works with the shared composite title function because somehow or another, the key accessor that title function sees is *not* the scatter override one. it has something to do with the title function capturing key+value accessors from its own closure, but i'm confused as heck and must be tired as well. ref #1200
|
Merged for 2.0. Thanks @daniel-gall! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to remove cruft from title code borrowed from lineChart.
#961