reasonable default for scatter plot titles

ref #1200
dc-js · Dec 23, 2016 · e1a1211 · e1a1211
1 parent dae8c84
commit e1a1211
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/spec/scatter-plot-spec.js b/spec/scatter-plot-spec.js
@@ -24,13 +24,7 @@ describe('dc.scatterPlot', function () {
             .emptySize(4)
             .emptyOpacity(0.5)
             .emptyColor('#DFFF00')
-            .transitionDuration(0)
-            .title(function (d) {
-                // because of the yucky way scatterPlot sets its own key/value accessors
-                // perhaps this should be defaulted within the scatter plot
-                return chart.keyAccessor()(d) + ',' + chart.valueAccessor()(d) + ': ' +
-                    chart.existenceAccessor()(d);
-            });
+            .transitionDuration(0);
     });
 
     describe('rendering the scatter plot', function () {

diff --git a/src/scatter-plot.js b/src/scatter-plot.js
@@ -32,6 +32,13 @@ dc.scatterPlot = function (parent, chartGroup) {
     _chart.valueAccessor(function (d) { return originalKeyAccessor(d)[1]; });
     _chart.colorAccessor(function () { return _chart._groupName; });
 
+    _chart.title(function (d) {
+        // this basically just counteracts the setting of its own key/value accessors
+        // see https://github.com/dc-js/dc.js/issues/702
+        return _chart.keyAccessor()(d) + ',' + _chart.valueAccessor()(d) + ': ' +
+            _chart.existenceAccessor()(d);
+    });
+
     var _locator = function (d) {
         return 'translate(' + _chart.x()(_chart.keyAccessor()(d)) + ',' +
                               _chart.y()(_chart.valueAccessor()(d)) + ')';