Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sharing of txstatedb.json - can be signed and validated without bitcoind #6

Merged
merged 12 commits into from
Jan 23, 2014
Merged

Allow sharing of txstatedb.json - can be signed and validated without bitcoind #6

merged 12 commits into from
Jan 23, 2014

Commits on Jan 23, 2014

  1. fix function scope errors

    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    a431cc3 View commit details
    Browse the repository at this point in the history

  2. add inputtxs.get and inputtxs.clear commands

    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    e3d46ab View commit details
    Browse the repository at this point in the history

  3. add ability to store redeem and clear redeem script 

    ...necessary for being able to sign p2sh multisig transactions
    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    dd6fb4b View commit details
    Browse the repository at this point in the history

  4. add ability to validate redeem script 

    the public keys and nreq ought to be able to reproduce the redeem script.  when
people starting passing file around, they need to be able to validate that the
public keys can correctly reproduce the redeem script.
    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    2bdf0f6 View commit details
    Browse the repository at this point in the history

  5. add ability to sign txs without connecting to bitcoind 

    ...if the user has used the inputtxs.get command, they can sign messages
without needing to connect to bitcoind to get the input transactions.
    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    26b2089 View commit details
    Browse the repository at this point in the history

  6. remove debug comment from some earlier time

    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    1bea3e6 View commit details
    Browse the repository at this point in the history

  7. remove newlines so that pubkey commands are together 

    ...just like the other command groups, like raw.*
    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    213df73 View commit details
    Browse the repository at this point in the history

  8. add redeem script sanity check 

    When collaborating to build a multisig address, the user will want to be
absolutely certain that the p2sh address is correct, because they don't want to
accidentally send bitcoins into obvlivion.  Each user will want to be confident
that their public key is in the redeem script. This is part of that check. The
user can see that their public key is in the list, and this check is making
sure that the redeem script actually contains that public key. Another check
that I will implement shortly is that the user will want to be confident that
they actually have the privatate key corresponding to their public key.
    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    beef76c View commit details
    Browse the repository at this point in the history

  9. added ability to check which priv keys a user has 

    It will be imortant for users to be able to confirm that they actually have the
private key corresponding to a public key in the p2sh redeem script. That is
what this commit does. Users can show a list of pubkeys in the db, and show
which pubkeys they have the privkey for. Checks are run both to make sure the
corresponding pubkey is in the user's wallet, AND that the corresponding
private key can actually rederive the public key correctly.
    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    06c5dc8 View commit details
    Browse the repository at this point in the history

  10. change language from "check" to "validate" for consistency 

    ...other similar commands use the word "validate", so we should use that to be
consistent.
    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    799d9bd View commit details
    Browse the repository at this point in the history

  11. alphabatize command lists

    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    4a4345c View commit details
    Browse the repository at this point in the history

  12. update code for pubkeys.validate to reflect "help"

    Ryan X. Charles committed Jan 23, 2014
    Configuration menu
    Copy the full SHA
    0c32e49 View commit details
    Browse the repository at this point in the history