Allow sharing of txstatedb.json - can be signed and validated without bitcoind #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK (note comments on dependent pull req, before clicking merge...) |
added 12 commits
January 22, 2014 20:27
...necessary for being able to sign p2sh multisig transactions
the public keys and nreq ought to be able to reproduce the redeem script. when people starting passing file around, they need to be able to validate that the public keys can correctly reproduce the redeem script.
...if the user has used the inputtxs.get command, they can sign messages without needing to connect to bitcoind to get the input transactions.
...just like the other command groups, like raw.*
When collaborating to build a multisig address, the user will want to be absolutely certain that the p2sh address is correct, because they don't want to accidentally send bitcoins into obvlivion. Each user will want to be confident that their public key is in the redeem script. This is part of that check. The user can see that their public key is in the list, and this check is making sure that the redeem script actually contains that public key. Another check that I will implement shortly is that the user will want to be confident that they actually have the privatate key corresponding to their public key.
It will be imortant for users to be able to confirm that they actually have the private key corresponding to a public key in the p2sh redeem script. That is what this commit does. Users can show a list of pubkeys in the db, and show which pubkeys they have the privkey for. Checks are run both to make sure the corresponding pubkey is in the user's wallet, AND that the corresponding private key can actually rederive the public key correctly.
...other similar commands use the word "validate", so we should use that to be consistent.
ryanxcharles
pushed a commit
that referenced
this pull request
Jan 23, 2014
Allow sharing of txstatedb.json - can be signed and validated without bitcoind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One person will need to use bitcoind to build the txstatedb.json using everyone's public key, but then once the transaction has been proposed, the txstatedb.json file can be shared amongst the signing parties, and they can sign the file without needing to connect to bitcoind. The txstatedb.json file contains the input transactions to make this possible. Basic validation can be performed on the transaction to make sure they are signing what they think they are signing. However, further validation should be included. The signer should be able to verify:
A few other important features should be added:
More advanced features that should be added later:
Note that this pull request builds on my previous pull request, but develops a very different feature (ability to sign and verify the txstatedb.json without being connected to bitcoind) and that's why it has a new pull request.