Sp 1085 #1093
Merged
Sp 1085 #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Override | ||
| public EventSchema getResultingEventSchema() { | ||
| return null; |
There was a problem hiding this comment.
Why does this method always return null?
There was a problem hiding this comment.
This is only temporary. In the future we probably will replace the class AdapterEventPreviewPipeline with a regular AdapterPipeline that uses a different sink.
I had to add it here to remove the dependency of the FileStreamProtocol with the internal adapter implementation.
If you have an idea on how to remove it, I'm happy to discuss it. If there is no quick solution, I would suggest to leave it as it is and remove it during the revision of the connect API.
dominikriemer
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1085.
Previously, the
FileStreamProtocolrequired another sink (SendToBrokerReplayAdapterSink) for the adapter preprocessing pipeline.The reason for this was that the
FileStreamProtocolneeds to adjust the timestamp for correct replay, but it was the only adapter / protocol that used a different sink.The
SendToBrokerReplayAdapterSinkclass was deleted and the code was moved directly to theFileStreamProtocol.Further, some minor refactoring was performed.
This should not be the final rewrite of the protocol, it is just a clean up step to better refactor the connect api.
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no