Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FileStreamProtocol #1085

Closed
tenthe opened this issue Jan 12, 2023 · 0 comments · Fixed by #1093
Closed

Refactor FileStreamProtocol #1085

tenthe opened this issue Jan 12, 2023 · 0 comments · Fixed by #1093
Assignees
@tenthe
Labels
connect Related to the `connect` module (adapters) enhancement New feature or request
Milestone
0.91.0

Comments

@tenthe
Copy link
Contributor

tenthe commented Jan 12, 2023

Body

The FileStreamProtocol can be used to replay event streams from files that are uploaded (e.g. csv file).
The protocol currently handles its own event schema and requires the SendToBrokerReplayAdapterSink class.
The logic of this class can be moved into the protocol so that it uses the regular connect API.

This issue should do some cleanup before we can start refactoring the connect API.

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
@tenthe tenthe added enhancement New feature or request connect Related to the `connect` module (adapters) labels Jan 12, 2023
@tenthe tenthe added this to the 1.0.0 milestone Jan 12, 2023
@tenthe tenthe self-assigned this Jan 12, 2023
tenthe added a commit that referenced this issue Jan 12, 2023
@tenthe
[#1085] Add getter for event schema to AdapterDescription
4981f12
tenthe added a commit that referenced this issue Jan 13, 2023
@tenthe
[#1085] Extract find timestamp property from FileStreamProtocol to Ev…
02059a8 
…entSchemaUtils
tenthe added a commit that referenced this issue Jan 13, 2023
@tenthe
[#1085] Replace thread with executor service in FileStreamProtocol
8fd0860
tenthe added a commit that referenced this issue Jan 14, 2023
@tenthe
[#1085] Remove SendToBrokerReplayAdapterSink and move code to FileStr…
9b1d370 
…eamProtocol
@tenthe tenthe mentioned this issue Jan 14, 2023
Merged
@bossenti bossenti modified the milestones: 1.0.0, 0.91.0 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenthe tenthe

Labels
connect Related to the `connect` module (adapters) enhancement New feature or request
Projects
None yet
Milestone
0.91.0
Development

Successfully merging a pull request may close this issue.

Sp 1085 apache/streampipes
2 participants
@tenthe @bossenti