Re-implement `` and '' with jumpTracker #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsschnau
force-pushed
the
issue-3138
branch
4 times, most recently
from
9fbabc0
to
4aa980d
Compare
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
`` and '' were implemented before the new
jumpTrackerin PR #3028 .This PR Fixes issue #3138.
Because
and '' were implemented before `jumpTracker`, this causedand '' to fall out-of-sync with jumpTracker, causing issue #3138 to surface.In addition, the
jumpTrackerimplementation requires jumps to be on separate lines. It so happens that the one-line example in #3138 identified this behavior. AFAIK the one-jump-per-line requirement isn't necessary. This PR removes it, instead requiring that different jumps be only on separate positions. @shawnaxsom, as the author of this bit, would you have any input on this?