-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement '' and ``. #1993
Implement '' and ``. #1993
Conversation
This is currently untested, pending acceptance of upstream patch. |
@brandonbloom Sorry, what's the difference between |
The difference is what happens f you execute the command twice in a row. Instead of going back, then back again, it goes back, then forward, alternating back and forth. Very useful for comparing things at distinct points the same file quickly: just hit tick or single-quote over and over again to flip back and forth. |
Nice job on the two repo attack here! It is pretty cool when your change gets merged into vscode and here and then the next release makes you happier :) |
@brandonbloom Awesome! Nice job! Could you add some tests for this feature? |
Are there any tests for CommandNavigateBack? |
Actually, I doubt we need tests for this; it's just a wrapper of the corresponding VSCode command. |
Actually, this doesn't seem to work on the current release. I'm guessing it's an issue with the keybindings. |
Check to see if the "Go Last" command is available in VS Code. My guess is not yet. |
Closes VSCodeVim#3138. `` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993. This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to surface. In addition, the jumpTracker implementation requires jumps to be on separate lines. As far as I can tell, this behavior is not neccesary. This commit removes that requirement, instead requiring that different jumps be only on separate positions.
Closes VSCodeVim#3138. `` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993. This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to surface. In addition, the jumpTracker implementation requires jumps to be on separate lines. As far as I can tell, this behavior is not neccesary. This commit removes that requirement, instead requiring that different jumps be only on separate positions.
Closes VSCodeVim#3138. `` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993. This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to surface. In addition, the jumpTracker implementation requires jumps to be on separate lines. As far as I can tell, this behavior is not neccesary. This commit removes that requirement, instead requiring that different jumps be only on separate positions.
Closes VSCodeVim#3138. `` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993. This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to surface. In addition, the jumpTracker implementation requires jumps to be on separate lines. As far as I can tell, this behavior is not neccesary. This commit removes that requirement, instead requiring that different jumps be only on separate positions.
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
Fixes #1089.
Dependency: microsoft/vscode#33715