Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decky Cloud Save v1.3.3 #519

Merged
merged 13 commits into from
Jan 21, 2024
Merged

Decky Cloud Save v1.3.3 #519

merged 13 commits into from
Jan 21, 2024

Conversation

GedasFX
Copy link
Contributor

@GedasFX GedasFX commented Jan 17, 2024

Decky Cloud Save v1.3.3

A plugin based on rclone, which allows users to back-up game saves to the cloud. Supports OneDrive, Google Drive, Dropbox, and many more!

Changes:

  • Bumped rclone version (1.61.1 to 1.65.1)
    ~ Minor fix for bisync experimental feature not working (thank you @TJSomething)

Also contains hidden feature from 1.3.2: #465. This is a hidden opt in feature that works for some people. Its opt in and doesn't affect the rest of the plugin so I think it can be in, otherwise I can remove it.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Preview Update Channel.

@GedasFX GedasFX requested a review from a team as a code owner January 17, 2024 08:17
@GedasFX GedasFX mentioned this pull request Jan 17, 2024
5 tasks
@TrainDoctor TrainDoctor requested a review from a team January 17, 2024 12:09
@TrainDoctor
Copy link
Member

Approved for testing store.

Copy link

@TJSomething TJSomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On more thorough testing, I can't approve this. Sorry I didn't see this earlier.

That said, the new exit code check is good for diagnosing issues.

Decky v1.10.10, Decky CloudSave - 1.3.3-79607de

  1. 1 blocking issue found:
    1. Using the expected procedure for enabling bisync makes it impossible to use the UI to disable bisync. It appears that the code is always using the second key in plugin.properties to determine if bisync is enabled, which on a clean install will be the experimental_menu setting, not the bisync_enabled setting.
  2. Non-blocking issue:
    1. Consider adding bisync documentation to recommend users perform a regular sync first, otherwise it fails with "Bisync critical errror: cannot find prior Path1 or Path2 listings, likely due to critical error on prior run".
  3. Other currently installed plugins: None
  4. No go for prod

@GedasFX
Copy link
Contributor Author

GedasFX commented Jan 20, 2024

@TJSomething

  1. Fixed the issue, I always tested this with experimental feature, now it looks for things correctly Use correct key in config, not just the second key GedasFX/decky-cloud-save#55
  2. Updated docs. GedasFX/decky-cloud-save@06830eb

Copy link

@TJSomething TJSomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decky v2.10.10, Decky CloudSave - 1.3.3-4200928

  1. No blocking issues found.
  2. No non-blocking issues found.
  3. Other currently installed plugins: None
  4. Approved for prod

@TrainDoctor TrainDoctor merged commit 231ad4e into SteamDeckHomebrew:main Jan 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants