Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decky Cloud Save v1.3.2 #465

Closed
wants to merge 9 commits into from
Closed

Conversation

GedasFX
Copy link
Contributor

@GedasFX GedasFX commented Oct 23, 2023

Decky Cloud Save v1.3.2

A plugin based on rclone, which allows users to back-up game saves to the cloud. Supports OneDrive, Google Drive, Dropbox, and many more!

Changes:

  • Added much requestedexperimental bisync support (thank you @NL-TCH). This is accessable by enabling new experimental menu.
  • Added experimental menu. Enabled by editing plugin.properties and setting experimental_menu=true. Support for features enabled by this toggle will not be provided.
  • Added ability to mute the toasts on sync completion (thank you @AkazaRenn).

FOR TESTERS: The experimental bisync is not rigorously tested and may cause issues, but is a much requested feature. I am not too sure how to proceed as I do not believe this would ever be a non-experimental feature. Should I just straight up remove it? I am new to open source development, and its a feature that I am not satisfied with, I really need feedback here 😅.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Preview Update Channel.

@GedasFX GedasFX requested a review from a team as a code owner October 23, 2023 19:22
@GedasFX GedasFX temporarily deployed to testing_env October 23, 2023 19:23 — with GitHub Actions Inactive
@TrainDoctor TrainDoctor added the enhancement New feature or request label Oct 24, 2023
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review checks out. Good to go to testing.

@TrainDoctor TrainDoctor requested review from a team October 24, 2023 00:29
@GedasFX
Copy link
Contributor Author

GedasFX commented Nov 5, 2023

Update: having issues passing testing, will recreate PR once its store-worthy. In its current state, this is not acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants