Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pnpm #823

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Remove pnpm #823

merged 4 commits into from
Apr 6, 2024

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Apr 6, 2024

This PR is an example of what it would look like to remove pnpm.

@neubig neubig requested review from rbren and dorbanianas April 6, 2024 12:10
Copy link
Collaborator

@dorbanianas dorbanianas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as you discussed reducing the number of dependencies that limit the supported platform would be a good thing👌

@neubig neubig merged commit f40fe6a into main Apr 6, 2024
@neubig
Copy link
Contributor Author

neubig commented Apr 6, 2024

OK, thanks for the discussion everyone!

lehcode pushed a commit to lehcode/oppendevin that referenced this pull request Apr 10, 2024
* Remove pnpm

* Remove from ci

* Remove pnpm

* Remove cache from lint
@iFurySt iFurySt deleted the neubig/remove_pnpm branch July 6, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing pnpm on mac Internal Error: EACCES: permission denied, symlink '.
2 participants